977845 - Australis: flickering of bookmark in bookmarks toolbar when exiting customize mode

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[Sören Hentzschel]

Attachment: bookmarks.mov

Hi!

I attached a short .mov-file (8 seconds). Please look at the end of the bookmarks toolbar after closing the customization tab. Do you see the additional bookmark for a very short moment?

Comment 1

[:Gijs (out for now; he/him)]

I don't think this is fixable without rearchitecturing how the bookmarks toolbar overflow works. It relies on overflow events, and to get those, it needs to just display everything. Marco, is that impression correct?

Comment 2

[Marco Bonardo [:mak]]

yes, and honestly I don't see how we may rearchitecture overflow without using overflow events...
What we may do here is add an overflow buffer that collects overflow/underflow events and delays them for a while to avoid flickering, by killing overflow/underflow that happen in a short timeframe.

Comment 3

[Marco Bonardo [:mak]]

though, in this case we show elements and then we hide them, so that wouldn't work. we could hide buttons so that they take up the space for overflow to happen, and then unhide them later

Comment 4

[:Gijs (out for now; he/him)]

(In reply to Marco Bonardo [:mak] from comment #3)
> though, in this case we show elements and then we hide them, so that
> wouldn't work. we could hide buttons so that they take up the space for
> overflow to happen, and then unhide them later

Fair point, we could get the 'unitialized' state have visibility: hidden on all the items instead of nothing, and presumably the overflow event would still happen?

Comment 5

[Marco Bonardo [:mak]]

it's worth a try...