getCurrentUrl does not match behaviour of the WebDriver spec

RESOLVED FIXED in mozilla35

Status

defect
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

(Blocks 1 bug, {pi-marionette-spec})

unspecified
mozilla35
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments, 2 obsolete attachments)

Assignee

Description

5 years ago
when calling getCurrentUrl we must return the top level browsing context url not the url of the current frame.
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attaching a first stab at a fix for this.  I'm not sure how to reliably access the parent frame of cross-domain documents.  Can we override the security permissions imposed by the DOM somehow?
Attachment #8392933 - Flags: review?(dburns)
Assignee

Updated

5 years ago
Attachment #8392933 - Flags: review?(dburns) → feedback?(dburns)
Assignee

Comment 2

5 years ago
Posted patch half completed getCurrentUrl (obsolete) — Splinter Review
Assignee

Updated

5 years ago
Assignee: ato → dburns
Assignee

Comment 3

5 years ago
To get the top level context we need to work mainly in the server code. I have half done the patch, it will need more testing

I would make sure we test on b2g because this may have unforeseen circumstances...
Assignee: dburns → ato
That approach looks more sane to me, thanks!
Assignee

Updated

5 years ago
Attachment #8392933 - Flags: feedback?(dburns)
Assignee

Updated

5 years ago
Whiteboard: [spec]
Assignee

Updated

5 years ago
Priority: -- → P3
It looks like patch attached by David Burns is already in master branch. Should it be closed?
Sorry, I misunderstood the diff.
Assignee

Updated

5 years ago
Assignee: ato → dburns
Assignee

Updated

5 years ago
Attachment #8393227 - Attachment is obsolete: true
Assignee

Updated

5 years ago
Attachment #8477783 - Attachment is obsolete: true
Comment on attachment 8483727 [details] [diff] [review]
getCurrentUrl in marionette should return the url for the top level document

Review of attachment 8483727 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little sad about disabling test_switch_frame on b2g, but I guess that kind of in-process frame switching isn't common there (or maybe never exists at all).
Attachment #8483727 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/1d1bca9ca7a3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.