977893 - getCurrentUrl does not match behaviour of the WebDriver spec

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[David Burns :automatedtester]

when calling getCurrentUrl we must return the top level browsing context url not the url of the current frame.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-977893-getCurrentUrl-should-return-that-of-the-t.patch

Attaching a first stab at a fix for this.  I'm not sure how to reliably access the parent frame of cross-domain documents.  Can we override the security permissions imposed by the DOM somehow?

Comment 2

[David Burns :automatedtester]

Attachment: half completed getCurrentUrl

Comment 3

[David Burns :automatedtester]

To get the top level context we need to work mainly in the server code. I have half done the patch, it will need more testing

I would make sure we test on b2g because this may have unforeseen circumstances...

Comment 4

[Andreas Tolfsen ❲:ato❳]

That approach looks more sane to me, thanks!

Comment 5

[Andrei Botalov [:abotalov]]

It looks like patch attached by David Burns is already in master branch. Should it be closed?

Comment 6

[Andrei Botalov [:abotalov]]

Sorry, I misunderstood the diff.

Comment 7

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=d01a09d8cace

Comment 8

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=2255f80e1cd8

Comment 9

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=ff3a0f95e6e9

Comment 10

[David Burns :automatedtester]

Attachment: getCurrentUrl in marionette should return the url for the top level document

Comment 11

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=dfb52410cffd

Comment 12

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=7390654cd1f2

Comment 13

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=da912b014d67

Comment 14

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=4909e98539f8

Comment 15

[David Burns :automatedtester]

Attachment: getCurrentUrl in marionette should return the url for the top level document

Comment 16

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8483727 [details] [diff] [review]
getCurrentUrl in marionette should return the url for the top level document

Review of attachment 8483727 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a little sad about disabling test_switch_frame on b2g, but I guess that kind of in-process frame switching isn't common there (or maybe never exists at all).

Comment 17

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d1bca9ca7a3

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d1bca9ca7a3