Closed Bug 977933 Opened 9 years ago Closed 9 years ago

Increase WebRTC logging temporarily to catch intermittent test failures

Categories

(Core :: WebRTC, defect)

Product:
Core
Component:
WebRTC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file, 1 obsolete file)

increase_webrtc_test_log_level.patch
1.09 KB, patch
Details | Diff | Splinter Review 
      No description provided.

        Attachment #8383430 -
        Flags: review?(rjesup)

    
    

    
  
Comment on attachment 8383430 [details] [diff] [review]
increase_webrtc_test_log_level.patch

Review of attachment 8383430 [details] [diff] [review]:
-----------------------------------------------------------------

Please run a Try before this lands to make sure the logging a) works, and b) doesn't generate so much logging as to choke tbpl/etc

        Attachment #8383430 -
        Flags: review?(rjesup) → review+

    
    

    
  
I see the Try is already running.  never mind :-)

    
    

    
  
I'm looking at the failures in test_dataChannel_basicAudioVideo.html...

    
  
Assignee: nobody → drno

    
  

        Attachment #8383430 -
        Attachment is obsolete: true

    
    

    
  


  
Try again with lower log level to avoid log truncation.

    
    

    
  
Either we just got lucky or it works better with log level 6.

    
    

    
  
I don't see any truncated log files any more. So I believe we are good.

    
    

    
  
Comment on attachment 8384780 [details] [diff] [review]
increase_webrtc_test_log_level.patch

Carrying forward r+=jesup

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5c960b9a5273
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

          You need to log in
          before you can comment on or make changes to this bug.