Move some flags to moz.build

RESOLVED FIXED in mozilla30

Status

defect
RESOLVED FIXED
6 years ago
Last year

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla30
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

No description provided.
Posted patch Move some flags to moz.build (obsolete) — Splinter Review
Assignee: nobody → ehsan
Attachment #8383461 - Flags: review?(mshal)
Attachment #8383461 - Flags: review?(mh+mozilla)
Attachment #8383461 - Flags: review?(gps)
Comment on attachment 8383461 [details] [diff] [review]
Move some flags to moz.build

Review of attachment 8383461 [details] [diff] [review]:
-----------------------------------------------------------------

::: hal/moz.build
@@ +189,5 @@
>          '/widget/xpwidgets'
>      ]
> +
> +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
> +    CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware_legacy/include']

This makes me sad. I'd been thinking of adding a ANDROID_INCLUDES or something like that.
(In reply to :Ms2ger from comment #2)
> Comment on attachment 8383461 [details] [diff] [review]
> Move some flags to moz.build
> 
> Review of attachment 8383461 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: hal/moz.build
> @@ +189,5 @@
> >          '/widget/xpwidgets'
> >      ]
> > +
> > +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
> > +    CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware_legacy/include']
> 
> This makes me sad. I'd been thinking of adding a ANDROID_INCLUDES or
> something like that.

File a follow-up please!
Attachment #8383461 - Attachment is obsolete: true
Attachment #8383461 - Flags: review?(mshal)
Attachment #8383461 - Flags: review?(mh+mozilla)
Attachment #8383461 - Flags: review?(gps)
Attachment #8384150 - Flags: review?(mshal)
Attachment #8384150 - Flags: review?(mh+mozilla)
Attachment #8384150 - Flags: review?(gps)
Comment on attachment 8384150 [details] [diff] [review]
Move some flags to moz.build

Review of attachment 8384150 [details] [diff] [review]:
-----------------------------------------------------------------

::: hal/moz.build
@@ +189,5 @@
>          '/widget/xpwidgets'
>      ]
> +
> +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk':
> +    CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware_legacy/include']

'-I%s/hardware/libhardware_legacy/include' % CONFIG['ANDROID_SOURCE']

::: media/omx-plugin/moz.build
@@ +49,5 @@
> +         '-I' + CONFIG['ANDROID_SOURCE'] + '/frameworks/base/media/libstagefright/include',
> +         '-I' + CONFIG['ANDROID_SOURCE'] + '/frameworks/base/native/include',
> +         '-I' + CONFIG['ANDROID_SOURCE'] + '/system/core/include',
> +         '-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware/include',
> +    ]

['-I%s/%s' % (CONFIG['ANDROID_SOURCE'], d) for d in [
    'dalvik/libnativehelper/include/nativehelper',
    'frameworks/base/include',
    ...
]]

::: netwerk/protocol/rtsp/moz.build
@@ +64,5 @@
>  for var in ('IMPL_NS_NET', 'FORCE_PR_LOG'):
>      DEFINES[var] = True
> +
> +if CONFIG['ANDROID_VERSION'] == '15':
> +    CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/frameworks/base/media/libstagefright/mpeg2ts']

-I%s/...
Attachment #8384150 - Flags: review?(mshal)
Attachment #8384150 - Flags: review?(mh+mozilla)
Attachment #8384150 - Flags: review?(gps)
Attachment #8384150 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/36bd9996d655
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.