Closed Bug 977964 Opened 11 years ago Closed 11 years ago

Move some flags to moz.build

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file, 1 obsolete file)

Move some flags to moz.build
7.64 KB, patch
glandium
: review+
Details | Diff | Splinter Review
No description provided.
Attached patch Move some flags to moz.build (obsolete) — — Splinter Review
Assignee: nobody → ehsan
Blocks: xulinmozbuild
Attachment #8383461 - Flags: review?(mshal)
Attachment #8383461 - Flags: review?(mh+mozilla)
Attachment #8383461 - Flags: review?(gps)
Comment on attachment 8383461 [details] [diff] [review] Move some flags to moz.build Review of attachment 8383461 [details] [diff] [review]: ----------------------------------------------------------------- ::: hal/moz.build @@ +189,5 @@ > '/widget/xpwidgets' > ] > + > +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk': > + CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware_legacy/include'] This makes me sad. I'd been thinking of adding a ANDROID_INCLUDES or something like that.
(In reply to :Ms2ger from comment #2) > Comment on attachment 8383461 [details] [diff] [review] > Move some flags to moz.build > > Review of attachment 8383461 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: hal/moz.build > @@ +189,5 @@ > > '/widget/xpwidgets' > > ] > > + > > +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk': > > + CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware_legacy/include'] > > This makes me sad. I'd been thinking of adding a ANDROID_INCLUDES or > something like that. File a follow-up please!
Attachment #8383461 - Attachment is obsolete: true
Attachment #8383461 - Flags: review?(mshal)
Attachment #8383461 - Flags: review?(mh+mozilla)
Attachment #8383461 - Flags: review?(gps)
Attachment #8384150 - Flags: review?(mshal)
Attachment #8384150 - Flags: review?(mh+mozilla)
Attachment #8384150 - Flags: review?(gps)
Comment on attachment 8384150 [details] [diff] [review] Move some flags to moz.build Review of attachment 8384150 [details] [diff] [review]: ----------------------------------------------------------------- ::: hal/moz.build @@ +189,5 @@ > '/widget/xpwidgets' > ] > + > +if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk': > + CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware_legacy/include'] '-I%s/hardware/libhardware_legacy/include' % CONFIG['ANDROID_SOURCE'] ::: media/omx-plugin/moz.build @@ +49,5 @@ > + '-I' + CONFIG['ANDROID_SOURCE'] + '/frameworks/base/media/libstagefright/include', > + '-I' + CONFIG['ANDROID_SOURCE'] + '/frameworks/base/native/include', > + '-I' + CONFIG['ANDROID_SOURCE'] + '/system/core/include', > + '-I' + CONFIG['ANDROID_SOURCE'] + '/hardware/libhardware/include', > + ] ['-I%s/%s' % (CONFIG['ANDROID_SOURCE'], d) for d in [ 'dalvik/libnativehelper/include/nativehelper', 'frameworks/base/include', ... ]] ::: netwerk/protocol/rtsp/moz.build @@ +64,5 @@ > for var in ('IMPL_NS_NET', 'FORCE_PR_LOG'): > DEFINES[var] = True > + > +if CONFIG['ANDROID_VERSION'] == '15': > + CXXFLAGS += ['-I' + CONFIG['ANDROID_SOURCE'] + '/frameworks/base/media/libstagefright/mpeg2ts'] -I%s/...
Attachment #8384150 - Flags: review?(mshal)
Attachment #8384150 - Flags: review?(mh+mozilla)
Attachment #8384150 - Flags: review?(gps)
Attachment #8384150 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/36bd9996d655
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: