Closed
Bug 97799
Opened 24 years ago
Closed 24 years ago
Incorrect DOM change on OBJECTs that have sub-documents
Categories
(Core :: Layout, defect, P5)
Core
Layout
Tracking
()
VERIFIED
FIXED
mozilla0.9.5
People
(Reporter: peterlubczynski-bugs, Assigned: peterlubczynski-bugs)
References
()
Details
Attachments
(2 files)
|
4.19 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.22 KB,
patch
|
Details | Diff | Splinter Review |
When I fixed bug 678 about using the OBJECT tag to embed documents of type
text/html (and others), I added a hack that changed the DOM. Instead of adding a
hidden "src" attribute so an nsFrameFrame would make it work just like an
iframe, the following patch correctly fixes nsFrameFrame to real the "data"
attribute.
| Assignee | ||
Comment 1•24 years ago
|
||
Comment 2•24 years ago
|
||
r=dcone
| Assignee | ||
Comment 3•24 years ago
|
||
Marc, can you super review?
Comment 4•24 years ago
|
||
sr=attinasi
| Assignee | ||
Comment 5•24 years ago
|
||
| Assignee | ||
Comment 6•24 years ago
|
||
The updated patch is slighted modified to remove iframe tag checking in
nsFrameFrame. It is possible that not just iframe tags (maybe framesets) can
take this code route and I don't want to change that. I also ensured that only
object type tags will embed documents, not the depricated applet or embed.
| Assignee | ||
Comment 7•24 years ago
|
||
Patch checked in, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 8•24 years ago
|
||
Marking verified in the Oct 22nd OS X and Windows builds.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•