978011 - Unload properly Image Loader when syncing/importing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[:gerard-majax]

Follow-up of bug 970832. We need some code to properly remove the event listeners when performing import operations.

Copy/paste of the suggestion that was on the pull request [https://github.com/mozilla-b2g/gaia/pull/16721]:

> I have also another additional idea to make the importer module safer if you're comfortable with it
> 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/importer_ui.js#L781
> Just after the user clicks on "Import button", we could call something like this:
> 
> imgLoader.unload(); // or imgLoader.uninit() or imgLoader.destroy(),...
> 
> This method should remove the listeners "scroll" and "onupdate" thought. > I guess that to keep listeners running does not make sense here.
> 
> What do you think @jmcanterafonseca ?

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Nominating for 1.4 since this solution looks safer, but requires some extra code that we don't want to add taking into account timeframe for 1.3

Comment 2

[David Scravaglieri [:scravag]]

Not a blocker, just land it if ready before March 17th

Comment 3

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Thanks for the review

Comment 4

[Jose Manuel Cantera]

Comment on attachment 8386631 [details]
Patch v1

works perfectly. please land once you get a green Travis.

Comment 5

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/mozilla-b2g/gaia/commit/e48412f1230b3a8c8603b1fc7222d4765601cd55

Comment 7

[Noemí Freire (:noemi)]

Tested on master (see environment details below). It is working as expected, with 1951 contacts in gmail server and selecting 10 contacts with photo, all the photos have been properly imported so nominating to v1.3

Device: Hamachi
Platform version: 30.0a1
Build ID: 20140307120944
Gecko: 83c9562
Gaia: 5bc9b5c

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8386631 [details]
Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Contacts photos are not imported properly. See bug 970832
[User impact] if declined: High impact on the experience. Phone appear as buggy
[Testing completed]: Yes, in master by the QA team. Also unit tests available
[Risk to taking this patch] (and alternatives if risky): Very low risk. 
[String changes made]: The image loader component is unloaded properly

Comment 9

[Jason Smith [:jsmith]]

Dupe of a 1.3+, which makes this a 1.3+ as well.

Comment 10

[Noemí Freire (:noemi)]

Hi Ryan,

Could you please help us with the uplift to v1.3 branch?. Thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v1.3: 5b75c885f0f29412942188fec0433e86ffdf36c3