978014 - [FDN] Edit FDN contact does not ask for PUK2 password when PIN2 gets blocked

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Pooja]

Prerequisite:
1. Should know PUK2 code before trying STR 

Steps to reproduce:
1. Go to Settings->Call Settings->Fixed dialing numbers->Authorized numbers
2. Edit any existing contact. It will ask for PIN2.
3. Enter wrong PIN2 three times so that PIN2 gets blocked

Expected Result:
It should ask for PUK2 code as PIN2 is already blocked.

Actual result:
It just returns back to fdn contact list page without editing contact.

This is because Gaia only handles "IncorrectPassword" (incorrect pin2) error case in updateFdnContact() function at [1].

And in rest all cases just print default error message 
"Error: Could not edit FDN contact on SIM card"

It doesn't handle "SimPuk2" (puk2 needed) error message

[1]https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/simcard_dialog.js line 239

Comment 1

[Pooja]

Any update on this?

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi EJ,
This is more like a bug rather than feature.
Could you take a look at this?

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Assign to EJ first, but very likely this can't be done before FL.
nominate 2.0? and target to fix before FC.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Yes, it looks like a bug and I think we can postpone this after S3 to fix.

I would update if I got any updates. thanks !

Comment 5

[howie [:howie]]

Hi David, the FDN feature is developed by Comms team, could you find the appropriate person to solve this? Thanks.

Comment 6

[howie [:howie]]

Hi Michal, do you mind taking a look? It's FDN feature bug related to gaia setting, thank you.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

nominate 2.1? for triage.
CAF requests this to be in 2.1.

Comment 8

[bhavana bajaj [:bajaj]]

(In reply to Wesley Huang [:wesley_huang] from comment #7)
> nominate 2.1? for triage.
> CAF requests this to be in 2.1.

Per email and offline conversation on this, setting the feature-b2g flag as 2.1 as this is being targeted for 2.1 FL

Comment 9

[Michał Budzyński (:michalbe)]

Hi, because of all the Contacts Haida work I have to finish this sprint, I don't think I'll find any time to work on FDN.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Is this target for this sprint? If so could we try to estimate the task, just to get used to estimations :)

Comment 11

[Maria Angeles Oteo (:oteo)]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #10)
> Is this target for this sprint? If so could we try to estimate the task,
> just to get used to estimations :)

Right now, it seems that Fernando has problems to reproduce/fix this bug due to his UK SIM card so it seems that he will not be able to work on it :(

Comment 12

[Fernando Campo (:fcampo)]

(In reply to Maria Angeles Oteo (:oteo) from comment #11)
> (In reply to Francisco Jordano [:arcturus] [:francisco] from comment #10)
> > Is this target for this sprint? If so could we try to estimate the task,
> > just to get used to estimations :)
> 
> Right now, it seems that Fernando has problems to reproduce/fix this bug due
> to his UK SIM card so it seems that he will not be able to work on it :(
Yep, right now I don't have access to any simcard with PIN2 or PUK2, waiting till monday to try at LDN's office.

Comment 13

[Fernando Campo (:fcampo)]

will get back to it as soon as I have access to SIMs to test with.

Comment 14

[howie [:howie]]

ni Bhavana and Wesley, could you provide more info regarding to Comment 8 and if this is 2.1 feature it needs Comms team to allocate resource to solve it. Thank you.

Comment 15

[bhavana bajaj [:bajaj]]

(In reply to howie [:howie] from comment #14)
> ni Bhavana and Wesley, could you provide more info regarding to Comment 8
> and if this is 2.1 feature it needs Comms team to allocate resource to solve
> it. Thank you.

That's correct, this was waived by CAF for 2.0 and and the expectation was to get this resolved in 2.1, hence comment #8.

Comment 16

[Francisco Jordano [:arcturus] [:francisco]]

Hei Fernando,

do you have the SIMs you needed?

Comment 17

[Fernando Campo (:fcampo)]

Sadly, no :( only have sims with PIN1 and PUK1, not the other ones.
Orange not helping much on the helpline. O2...well, you know O2.

Only one left is my spanish personal card, but I don't want to mess much with it, being away.

Comment 18

[Anshul]

Once bug 1020757 lands, it would be pretty easy to fix this bug by calling handleCardLockError from within the updatefdncontact at https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/simcard_dialog.js#241. Wondering if you would be able to take this bug as well?

Comment 19

[Kai-Chih Hu [:khu]]

Wesley, can you please find an owner as soon as possible? Thanks!

Comment 20

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

This sounds like a regression of this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=976470

Comment 21

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to Sergi Mansilla [:sergi] (Telenor) from comment #20)
> This sounds like a regression of this bug:
> https://bugzilla.mozilla.org/show_bug.cgi?id=976470

And, do you mean this is more like a regression rather than feature?
Are you still working on this? We would need ETA estimation.

Comment 22

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Sergi will resume working on this. 
ETA and target milestone are set accordingly.

Comment 23

[bhavana bajaj [:bajaj]]

NI: sergi can you update where we are here on this, the ETA is set for topday (9/19) and I see nothing here.

Comment 24

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi,

I'm pretty sure this bug is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1020757, and I have been waiting for feedback on that one for a while. The good news is that I got a SIM card today that might allow me to test all the scenarios of the bug and hopefully close these issues.

Sergi

Comment 25

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github PR

Comment 26

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8493042 [details] [review]
Github PR

LGTM, Sergi do you think we can have any unit test?

If no, perhaps we could do a follow up.

Comment 27

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Francisco, this code is likely to change in the near future because of https://bugzilla.mozilla.org/show_bug.cgi?id=1070961. Besides, the FDN/PIN2 dialog is likely to be refactored a bit with some coming issues. I'd like to open a follow-up bug that tests simcard_dialog.js instead of adding tests to this one. Sounds good?

Comment 28

[Francisco Jordano [:arcturus] [:francisco]]

Definitely, let's land the fix, and we do the follow up.

Thanks!

Comment 29

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged at e1fd99454b6cd5da4f2c58f928fc04c6d03f478f

Comment 30

[Anshul]

Comment on attachment 8493042 [details] [review]
Github PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 31

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/e3ca7e8a0fc77d0381e40fb616c805e0e9f923bc

Comment 32

[Shally Li（leave from Mozilla）]

    This issue has been successfully verified on Flame 2.1&2.2.
    See attachment: verified_v2.1.MP4.
    Reproducing rate: 0/5
 
    But this bug also exist on Flame 2.0.
    See attch:v2.0_1226.mp4 and logcat_1226.txt.
    Reproducing rate: 5/5

Flame 2.0 build:
Gaia-Rev        f9d6e3d83c3922e9399a6c27f5ce4cdd27bdfd05
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/45112935086f
Build-ID        20141126000203
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.032754
FW-Date         Wed Nov 26 03:28:05 EST 2014
Bootloader      L1TC00011880

Flame 2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.033519
FW-Date         Wed Nov 26 03:35:30 EST 2014
Bootloader      L1TC00011880

FLame 2.2 build:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141125.113029
FW-Date         Tue Nov 25 11:30:43 EST 2014
Bootloader      L1TC00011880

Comment 33

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1.MP4

Comment 34

[Shally Li（leave from Mozilla）]

Attachment: logcat_1226.txt

Comment 35

[Shally Li（leave from Mozilla）]

Attachment: v2.0_1226.mp4