The default bug view has changed. See this FAQ.

Use a bright color for the outline of the tab strip in customization mode with certain themes

RESOLVED FIXED in Firefox 29

Status

()

Firefox
Toolbars and Customization
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: phlsa, Assigned: Gijs)

Tracking

30 Branch
Firefox 30
x86
Windows XP
Points:
---

Firefox Tracking Flags

(firefox29 fixed, firefox30 fixed)

Details

(Whiteboard: [Australis:P3])

Attachments

(2 attachments)

Created attachment 8383594 [details]
Hardly visible outlines

With the Windows XP themes »Luna blue (default)« and »Windows Classic«, the outline of the customizable area in the tab strip is hardly visible. It should use white as the color in these cases.

I guess this problem will also arise on Windows 8 when the window color is too dark and possibly even on Windows 7 (I don't have a test setup for the latter).
(Assignee)

Comment 1

3 years ago
Created attachment 8385324 [details] [diff] [review]
fix the hovered outline-color for Australis' customize mode's drag indicators for tabsintitlebar menubar/tabstoolbar to be the caption text color,

So this will do the right thing on XP, I'm pretty sure, but on Win7/Win8 we don't know what the window color is so we also can't do much else. However, this patch uses the captiontext color, so once we add support for fixing that, we might get support for win8 for free (or we might need to update to another constant, but either way, it should be less work to fix stuff).
Attachment #8385324 - Flags: review?(MattN+bmo)
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8385324 [details] [diff] [review]
fix the hovered outline-color for Australis' customize mode's drag indicators for tabsintitlebar menubar/tabstoolbar to be the caption text color,

Review of attachment 8385324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with :not([inFullscreen]) on the window

::: browser/themes/windows/browser.css
@@ +54,5 @@
>  #main-window[tabsintitlebar] #main-menubar > menu:not(:-moz-lwtheme):-moz-window-inactive {
>    color: InactiveCaptionText;
>  }
>  
> +#main-window[customize-entered][tabsintitlebar] #toolbar-menubar[customizing-dragovertarget].customization-target::before,

Since LWT don't apply in customization mode, we don't need to special-case that (contrary to what I said in person).

I think we should do :not([inFullscreen]) since the titlebar colour isn't shown behind these toolbars in fullscreen. (See the block "/* Use lighter colors of buttons and text in the titlebar on luna-blue */")
Attachment #8385324 - Flags: review?(MattN+bmo) → review+
(Assignee)

Comment 3

3 years ago
w/ nit

remote:   https://hg.mozilla.org/integration/fx-team/rev/86ef16e078a3
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/86ef16e078a3
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 30
(Assignee)

Comment 5

3 years ago
Comment on attachment 8385324 [details] [diff] [review]
fix the hovered outline-color for Australis' customize mode's drag indicators for tabsintitlebar menubar/tabstoolbar to be the caption text color,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: invisible outlines on the tabstoolbar/menubar on certain OS themes, meaning it's harder to figure out how/where to customize
Testing completed (on m-c, etc.): on m-c, locally
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none
Attachment #8385324 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

3 years ago
Whiteboard: [Australis:P3] → [Australis:P3][dont land on aurora before bug 931108 and co land]
status-firefox29: --- → affected
status-firefox30: --- → fixed
Attachment #8385324 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

3 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/f948eb47b645


Note for QA: this is effectively not testable because bug 978048 removed the outlines entirely.
status-firefox29: affected → fixed
Whiteboard: [Australis:P3][dont land on aurora before bug 931108 and co land] → [Australis:P3]

Updated

3 years ago
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.