Open Bug 978055 Opened 6 years ago Updated 2 years ago

Evaluate if it's possible to use different browser overlays for different applications when running mochitest-browser-chrome

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: mcsmurf, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

This is a problem that mainly affects SeaMonkey for now (don't stop reading at this point ;), the problem is that some rather new code in browser-test.js only works in Firefox, for example http://hg.mozilla.org/mozilla-central/annotate/26020d6a32f2/testing/mochitest/browser-test.js#l412
Now I thought of the idea to create a copy of that file for SeaMonkey only which gets included via a new browser overlay. Then all the Firefox-only stuff could be removed in this copy. Currently all applications (Firefox, B2G, SeaMonkey, Webapp RT) use the same overlay and therefor all the same copy of browser-test.js:
http://hg.mozilla.org/mozilla-central/annotate/26020d6a32f2/testing/mochitest/runtests.py#l508
This is something I hacked to together to make it possible to run mochitest-browser-chrome in SeaMonkey. But I don't think this patch would be good enough for checkin IMHO. The if-checks are ok, but not really sure about the try...catch :)
This is something I hacked to together to make it possible to run mochitest-browser-chrome in SeaMonkey. But I don't think this patch would be good enough for checkin IMHO. The if-checks are ok, but not really sure about the try...catch :)
Attachment #8383604 - Attachment is obsolete: true
Originally this code was added by Bug 932898. BTW: Are B2G and Webapp RT not affected by this code? Or are there currently no tests in those applications that use this code?
Component: Mochitest Chrome → Mochitest
You need to log in before you can comment on or make changes to this bug.