978111 - Some PSM xpcshell tests are disabled on Android and B2G even though they work

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P3)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #676972 +++

> However, all 3 xpcshell tests in security/manager/ssl/tests/unit hang
> consistently if run on Android.

It seems like the original test failures that motivated the the filing of bug 676972 have already been resolved, because the following tests all pass on Android:

[test_datasignatureverifier.js]
[test_hash_algorithms.js]
[test_hmac.js]

[test_sts_preloadlist_perwindowpb.js]
[test_sts_preloadlist_selfdestruct.js]
[test_sts_holepunch.js]
[test_sts_ipv4_ipv6.js]

Similarly, these tests are now passing consistently on B2G.

So, let's stop disabling at least this subset of tests on these platforms.

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: enable-already-working-tests.patch

https://tbpl.mozilla.org/?tree=Try&rev=7351cacd1a68

Note that the S4 test failure(s) is/are due to unrelated tests. If you open the full log you will see that all of the tests that are enabled here are passing.

I retriggered the tests a few time to detect intermittent failures. I did the same last night and several runs were all green so I think we're good to go.

Comment 2

[Camilo Viecco (:cviecco)]

Comment on attachment 8383842 [details] [diff] [review]
enable-already-working-tests.patch

Review of attachment 8383842 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, I am delayin the r+ until the b2g passes xpchell

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a261f24efc1

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b52006f691b

I disabled test_sts_preloadlist_perwindowpb.js on B2G/ARM due to perma-orange. I filed bug 978426 to re-enable it.

Also, there was a repeated typo in my original patch:

    fail-if = os == "android" || buildapp == "b2g""

I replaced this with:

    fail-if = os == "android" || buildapp == "b2g"

(Notice one less double-quote at the end.)

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8a261f24efc1
https://hg.mozilla.org/mozilla-central/rev/8b52006f691b