978129 - gfxFontUtils::DecodeFontName shouldn't assert on empty name string

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Jonathan Kew [:jfkthame]]

See bug 963492 comment 8. We don't need an assertion here:

  http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxFontUtils.cpp#1278

as it's possible (though not particularly likely or advised) for there to be a zero-length name table string.

An NS_WARNING might occasionally prove useful. I wouldn't be surprised if certain name strings being empty could make a font unusable on some systems.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: don't assert when decoding empty 'name' table strings.

Comment 2

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b64a3c8d9172

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b64a3c8d9172