Closed Bug 978140 Opened 10 years ago Closed 7 years ago

Firefox Metro 28.0 can't be built

Categories

(Firefox for Metro Graveyard :: Build Config, defect)

Product:
Firefox for Metro Graveyard
Component:
Build Config
Version:
28 Branch
Platform:
x86_64
Windows 8
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: xunxun1982, Unassigned)

References

Details

If using --disable-updater to build FirefoxMetro 28beta (VC2010), it will produce the error below:

nsAppRunner.cpp
d:/hg/beta/full/mozilla-beta/toolkit/xre/nsAppRunner.cpp(131) : fatal error C1083: Cannot open include file:“updatehelper.h”: No such file or directory
Native command 'mozbuild.action.cl main' returned value '2'

d:\hg\beta\full\mozilla-beta\config\rules.mk:1031:0: command 'mozbuild.action.cl main  cl -FonsAppRunner.obj -c -D_HAS_EXCEPTIONS=0 -I../../dist/stl_wrappers  -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -DNOMINMAX -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZ_APP_NAME='"firefox"' -DMOZ_APP_VERSION='"28.0"' -DOS_TARGET='"WINNT"' -DMOZ_WIDGET_TOOLKIT='"windows"' -DTARGET_XPCOM_ABI='"x86-msvc"' -DTARGET_OS_ABI='"WINNT_x86-msvc"' -DGRE_MILESTONE='28.0' -DAPP_VERSION='28.0' -DAPP_ID='{ec8030f7-c20a-464f-9b0e-13a3a9e97384}' -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DNO_NSPR_10_SUPPORT -DTOOLKIT_EM_VERSION='"28.0"' -DGRE_BUILDID=20140301013124 -Id:/hg/beta/full/mozilla-beta/toolkit/xre -I. -Id:/hg/beta/full/mozilla-beta/ipc/chromium/src -Id:/hg/beta/full/mozilla-beta/ipc/glue -Id:/hg/beta/full/obju-vc-nopgo/ipc/ipdl/_ipdlheaders -Id:/hg/beta/full/mozilla-beta/testing/gtest/mozilla -Id:/hg/beta/full/mozilla-beta/toolkit/xre/../profile -Id:/hg/beta/full/mozilla-beta/dom/ipc -Id:/hg/beta/full/mozilla-beta/toolkit/crashreporter -Id:/hg/beta/full/mozilla-beta/dom/base -Id:/hg/beta/full/mozilla-beta/xpcom/build -Id:/hg/beta/full/mozilla-beta/config  -I../../dist/include  -Id:/hg/beta/full/obju-vc-nopgo/dist/include/nspr -Id:/hg/beta/full/obju-vc-nopgo/dist/include/nss       -MD            -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -Oy     d:/hg/beta/full/mozilla-beta/toolkit/xre/nsAppRunner.cpp' failed, return code 2

<xulapp_s.lib.desc>: Found error


Why Firefox Metro needs to be depend on update module?
Blocks: metrobacklog
Whiteboard: [triage]
nsAppRunner.cpp calls LaunchDefaultMetroBrowser() : https://mxr.mozilla.org/mozilla-beta/source/toolkit/xre/nsAppRunner.cpp#4179

But LaunchDefaultMetroBrowser() is in here : https://mxr.mozilla.org/mozilla-beta/source/toolkit/mozapps/update/common/updatehelper.cpp#749

I can see https://mxr.mozilla.org/mozilla-beta/source/toolkit/mozapps/update/moz.build

It seems that
------------
14         if CONFIG['OS_ARCH'] == 'WINNT':
15             DIRS += ['common-standalone']
------------
position is not right
No longer blocks: metrobacklog
Whiteboard: [triage]
Summary: Firefox Metro can't be built using --disable-updater → Firefox Metro 28.0 can't be built
Blocks: metrobacklog
I also use --disable-maintenance-service
Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.