Closed
Bug 978197
Opened 12 years ago
Closed 12 years ago
Simplify the process to map a setting and a pref
Categories
(Firefox OS Graveyard :: General, defect)
Firefox OS Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S3 (14mar)
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
|
9.71 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
We have added so many simple settings those last months that it starts to makes me feel upset.
Attachment #8383847 -
Flags: review?(fabrice)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8383847 [details] [diff] [review]
setting.map.patch
Review of attachment 8383847 [details] [diff] [review]:
-----------------------------------------------------------------
::: b2g/chrome/content/settings.js
@@ +640,5 @@
> + defaultValue: 'manual'
> + },
> + 'ril.sms.strict7BitEncoding.enabled': {
> + prefName: 'dom.sms.strict7BitEncoding',
> + defaultValue: false
nit: whitespace alert!
Attachment #8383847 -
Flags: review?(fabrice) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
I killed the extra space :)
https://hg.mozilla.org/integration/b2g-inbound/rev/d1cb2e804e12
Assignee: nobody → 21
Status: NEW → ASSIGNED
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S3 (14mar)
You need to log in
before you can comment on or make changes to this bug.
Description
•