97825 - "Edit Attachment As Comment" relies on Mozilla bug 34297

Status: RESOLVED WORKSFORME

(Bugzilla :: Attachments & Requests, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

The "Edit Attachment As Comment" feature of the "Edit Attachments" screen relies
on the existence of bug 34297 (form controls with style="display: none;"
unsuccessful in Mozilla) in Mozilla-based browsers like Netscape 6.1.  When that
bug is fixed, this feature will break for those browsers.  It may already be
broken for other partially standards-compliant browsers like IE 5-6 for the Mac
and Windows.

The code should be rewritten to work across all browsers that have enough DOM1
standards-compliance to support it, regardless of how they treat display: none
form fields.

Comment 1

[Ben Bucksch (:BenB)]

I see an XMLSerializer in there too. Does it rely on XMLExtras? If so, it won't
work with Beonex Communicator as-is. (I disabled it, because I don't like
webpages calling home without me triggering it directly and because it might
have extra security holes.) But maybe you can convince me that xmlextras is so
useful and cool and world-changing and well-thought that it makes sense to
enable it :-). The other solution should be clear: Feed the full attachment
embedded directly inside the page.

Comment 2

[Gervase Markham [:gerv]]

Myk, Ben - the bug you mention has been fixed, but Edit Attachment As Comment
still works...

Gerv

Comment 3

[Matthew Tuck [:CodeMachine]]

Bug #52334?

Comment 4

[Bradley Baetz (:bbaetz)]

Maybe bug 108389?

I did a packet trace, and the forms with display: none are not being transmitted
to the server - the normalizeComments function takes care of that.

jkeiser, can you please look at teh source for an edit attachment page, and see
if you see anything broken in this regard?

Comment 5

[Bradley Baetz (:bbaetz)]

Bug 108309, rather, which was just fixed.

Comment 6

[John Keiser (jkeiser)]

I don't see anything invalid, and what's more to the point, Undo Edit As Comment
does not make us submit the value, nor does Edit Attachment As Comment make us
send the little comments field.

I say FIXED or WORKSFORME.

Comment 7

[Bradley Baetz (:bbaetz)]

WFM, then.

Comment 8

[Dave Miller [:justdave]]

clearing milestones on DUPLICATE/WONTFIX/WORKSFORME/INVALID bugs (so they'll
show up as needing triage if they get reopened)