978275 - FxA Test App - dismiss overlay after a while

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FxA, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Right now, if the FxA Test App fails to getAccounts, the overlay never goes away, and you have to kill the app and reopen. This is annoying, because when you set debugger breakpoints, those are all lost when the app is closed.

So: on Overlay.show(), set a generous timer (2 sec maybe) that calls Overlay.hide(), just in case.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github pull request 16753

Really minor thing, but it bothers me every time the test app overlay hangs open forever.

I'm not personally a fan of no-brackets conditional statements, but did it in keeping with the style elsewhere in the file.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8383955 [details] [review]
Github pull request 16753

Use brackets in the conditional statements, please.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

ferjm: updated the patch with brackets. anything else I need to do? I haven't gotten to this part of the review cycle before ;-P

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Heh, after getting the r+ and adding the requested changes to the PR, you can just merge the patch (if Travis is green) or set the checkin-needed flag, so anyone with merge permissions can do it for you.

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Add r=ferjm to the commit message, please. I'll merge the patch after that. Thanks!

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

sweet. thanks for the explanation :-)

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/1ed301a9d63859e0952740355dd2a7669e577bc7