97835 - We incorrectly linkify words with '@' characters

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Scott MacGregor]

Try sending yourself a message with a word that contains an @ sign like:

"hey, let's meet @8pm tonight."

When you view the message in mozilla, we turn the @8pm into a mailto url.  Oops!!!

We should only linkify if we see a '.' in the same word after the @ sign. That's
not a perfect solution but it should reduce the number of false positives for
mailto url detection. 

i.e. [e-mail] would get linkified because a period follows the @.
but @8pm wouldn't be linkified.

Comment 1

[Scott MacGregor]

Attachment: the fix

Comment 2

[(not reading, please use [e-mail] instead)]

inString.FindChar('.', pos) > 0

try

inString.FindChar('.', pos) != kNotFound

otherwise, r/sr=sspitzer

Comment 3

[Scott MacGregor]

I did that. thanks for the suggestion Seth. 

Comment 4

[Warner Young]

Sorry for the spam, but I was wondering, should this also check for a
non-whitespace character before the @ character?  Or is that already done somewhere?

Comment 5

[Scott MacGregor]

that's already done somewhere else.  i shouldn't have typed @8pm as my test.
Think of i'll meet u@8pm 

Comment 6

[varada]

r=varada

Comment 7

[Markus Gerstel]

Whats about something@. and something@.some ?

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

The patch should probably also check that there is no whitespace after the period. 

For example:  i'll meet u@8pm. later!

Comment 9

[Markus Gerstel]

But : Please notify [e-mail].
The last . should be stripped away.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 47847 [details] [diff] [review]
the fix

a=asa on behalf of drivers.

Comment 11

[Scott MacGregor]

fixed

Comment 12

[laurel]

OK using sept 04 commercial trunk builds: win98, linux rh6.2 and mac OS 9.0

Comment 13

[Ben Bucksch (:BenB)]

eh, mscott, that bug is filed already since long time, and you own it.

Note that fixing this bug will make linking internal email addresses (like
<ben@myhost>) impossible.

> Whats about something@. and something@.some
That should be handled by the network component, because <mailto:something@.> is
not a valid URL (and we only link to valid URLs).

Comment 14

[Ben Bucksch (:BenB)]

*** Bug 37215 has been marked as a duplicate of this bug. ***