Closed Bug 978455 Opened 10 years ago Closed 10 years ago

Separate registration from call-url generation

Categories

(Hello (Loop) :: Server, defect)

Product:
Hello (Loop)
Component:
Server
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: abr, Assigned: alexis+bugs)

References

Details

Attachments

(1 file)

link to github PR
46 bytes, text/x-github-pull-request
abr
: review+
Details | Review 
The current code is written to register the simple push URL at the same time as a call URL is generated. In practice, we need to have the push URL registration happen as soon as the browser starts (or when the user logs in, if they aren't logged in at browser startup) rather than upon call-url generation.
Attached file link to github PR — 

        Attachment #8384148 -
        Flags: review?(adam)

    
    

    
  
Updated, can you have another look?

    
    

    
  
Comment on attachment 8384148 [details] [review]
link to github PR

Looks good as of 08ed820. Thanks.

        Attachment #8384148 -
        Flags: review?(adam) → review+

    
    

    
  
https://github.com/mozilla/loop-server/commit/fd133ea84decb0007f1d78ca427e9de020c8b85e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Closing out older bugs. Code is newer than these changes.
Status: RESOLVED → VERIFIED

    
  
QA Contact: jbonacci

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: