The default bug view has changed. See this FAQ.

for mozharness desktop builds, replace usage of client.mk with upcoming mach/python script

RESOLVED FIXED

Status

Release Engineering
Mozharness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jlund, Assigned: jlund)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozharness])

Attachments

(2 attachments)

Comment hidden (empty)
Depends on: 978211
(Assignee)

Comment 1

3 years ago
Created attachment 8451678 [details] [diff] [review]
140706_bug_978211_proxy_script_mach_automation-mozharness.patch

This patch preps mozharness for 'mach build'. It won't land until latest
build-config changes make it to m-c.

Overview:

- fights some bitrot
- adds 'mach build' and supporting logic + removes un-needed make target calls
- adds configs for windows and mac
- changes how we deal with return_code and automation. it is only handled in
  summarize.
- partial mar is not included here (we will be using ffledgling's service
  eventually)
- snippets also are not included (we will just be using balrog)

this patch will only affect existing linux builders in cedar. will land a buildbot patch to turn on mac and windows after https://bugzilla.mozilla.org/show_bug.cgi?id=978211#c70 is fixed up.


log example of what this new build will look like for a linux32 opt build: http://dev-master1.srv.releng.scl3.mozilla.com:8037/builders/Linux%20mozilla-central%20build/builds/84/steps/run_script/logs/stdio
Attachment #8451678 - Flags: review?(aki)

Comment 2

3 years ago
Comment on attachment 8451678 [details] [diff] [review]
140706_bug_978211_proxy_script_mach_automation-mozharness.patch

r+ with a caveat.

>- partial mar is not included here (we will be using ffledgling's service
>  eventually)

Who was part of this decision?  If thought was put into this, I'll roll with it.  Aiui, however, we moved away from generating partials on a single machine and went with on-slave partials, to avoid having partial generation going well into the next day after a nightly, resulting in most people downloading full updates.  I haven't been following, but unless that's been resolved, that sounds like we may want to keep on-slave partials for the most common scenario(s) and use funsize for the next most common scenarios.

>- snippets also are not included (we will just be using balrog)

sgtm.

I'm largely *stamp*ing the changes, but didn't catch anything else egregious.
Attachment #8451678 - Flags: review?(aki) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8452809 [details] [diff] [review]
140708_bug_978211_proxy_script_mach_automation-mozharness.patch

r=aki

accidentally added a change I had in my testing env.
Attachment #8452809 - Flags: review+
(Assignee)

Comment 4

3 years ago
Comment on attachment 8452809 [details] [diff] [review]
140708_bug_978211_proxy_script_mach_automation-mozharness.patch

Review of attachment 8452809 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/mozharness/rev/f2b8bf507e9a
Attachment #8452809 - Flags: checked-in+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8451678 [details] [diff] [review]
140706_bug_978211_proxy_script_mach_automation-mozharness.patch

Review of attachment 8451678 [details] [diff] [review]:
-----------------------------------------------------------------

I am submitting this patch as cedar does not run nightly anyway.

However, until the future of funsize and partial mar's are clarified, I will follow up in this bug with re-adding partial mar gen. Rather than sticking it into build configs, I will most likely add it to the 'update' action before we submit to balrog.

checked in: http://hg.mozilla.org/build/mozharness/rev/28a22339cb48
Attachment #8451678 - Flags: checked-in+

Updated

3 years ago
Component: General Automation → Mozharness
In production
(Assignee)

Comment 7

3 years ago
this was done a while ago. I will follow up with some bugs to track its rolling out across remaining branches
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.