978540 - [e10s] correctly maintain active state for remote docShells

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

The non-remote browser binding has a .docShellIsActive property that silently fails when this.docShell is undefined. We should implement the same for the remote-browser binding to have background tabs de-prioritized.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-978540-e10s-Correctly-maintain-active-state-for-.patch

Making remoteBrowser.docShellIsActive write-only makes it a little easier to implement. We would otherwise need to sync the active state with the tabParent whenever that changes. It is only ever written to in our current code, there are a few mochitests that read it but those can be rewritten in the future.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8384228 [details] [diff] [review]
0001-Bug-978540-e10s-Correctly-maintain-active-state-for-.patch

Review of attachment 8384228 [details] [diff] [review]:
-----------------------------------------------------------------

Olli should review this since I'm not a DOM peer.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8384228 [details] [diff] [review]
0001-Bug-978540-e10s-Correctly-maintain-active-state-for-.patch


>+++ b/dom/interfaces/base/nsITabParent.idl
>@@ -15,9 +15,11 @@ interface nsITabParent : nsISupports
>                         [array, size_is(count)] in uint32_t aRxs,
>                         [array, size_is(count)] in uint32_t aRys,
>                         [array, size_is(count)] in float aRotationAngles,
>                         [array, size_is(count)] in float aForces,
>                         in uint32_t count,
>                         in long aModifiers);
> 
>   readonly attribute boolean useAsyncPanZoom;
>+
>+  void setIsDocShellActive(in bool aIsActive);
update uuid of nsITabParent

>+bool
>+TabChild::RecvSetIsDocShellActive(const bool& aIsActive)
>+{
>+    nsCOMPtr<nsIDocShell> docShell = do_GetInterface(mWebNav);
>+    docShell->SetIsActive(aIsActive);
Null check docShell.

>+        <setter>
>+          <![CDATA[
>+            let {frameLoader} = this.QueryInterface(Ci.nsIFrameLoaderOwner);
uh, JS has some horrible looking syntax these days.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/2fc218e7ad72

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Pushed to fix build bustage:

https://hg.mozilla.org/integration/fx-team/rev/4201e638f683

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2fc218e7ad72
https://hg.mozilla.org/mozilla-central/rev/4201e638f683