978546 - Do not dispatch touch events to the current app while dragging the utility-tray

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

When dragging the utility-tray the finger can moved fast enough so that the finger is not over it, but instead is over the current application. As a result touchmove events are dispatched to the applications while dragging the utility tray.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug978546.patch

Asking Etienne to review as he is the one involve in touch forwarding things. Even if this one is not a manual touch forward. Feel free to redirect to Alive if you feel uncomfortable reviewing this.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8384242 [details] [diff] [review]
bug978546.patch

Review of attachment 8384242 [details] [diff] [review]:
-----------------------------------------------------------------

Could reproduce the issue in the gallery, and this indeed fixes it.
And the screen.utility-tray css class is nicely covered by the utility tray unit tests so r=me.

But we should maybe do the same of the attention screen windows, since the utility tray can be displayed on top of them.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Etienne Segonzac (:etienne) from comment #2)
> Comment on attachment 8384242 [details] [diff] [review]
> bug978546.patch
> 
> Review of attachment 8384242 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Could reproduce the issue in the gallery, and this indeed fixes it.
> And the screen.utility-tray css class is nicely covered by the utility tray
> unit tests so r=me.
> 
> But we should maybe do the same of the attention screen windows, since the
> utility tray can be displayed on top of them.

I will open a followup for the attention screen part as it will require new tests :)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/06a8c1dbe6073f5f2343f017fb72d384723ffa35