978560 - checkmark menuitems in panels do not have padding for unchecked items

Status: RESOLVED DUPLICATE of bug 960198

(Firefox :: Menus, defect)

Description

[Tim Nguyen :ntim]

The menu bar sidebars popup doesn't show the checkmark and the icon at the same time when a social provider is selected, we should do the same with the widget.

Comment 1

[Tim Nguyen :ntim]

Attachment: Screenshot of issue

(Note that the checkmark is different because I'm using an userstyle)
But you can still see the issue without an userstyle.

Comment 2

[Justin Dolske [:Dolske]]

Yeah, there should be an empty column for where the checkmarks go. Other menus do this.

Comment 3

[Shane Caraveo (:mixedpuppy)]

This is actually a generic issue with menu's in panels.  You can reproduce this with the history panel, just select to open the history sidebar.  Then go back to the history panel, you'll see that the menuitem has adjusted to allow space for the checkmark.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: historycheckmark.png

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: osxmenu.png

osx menu does have padding for checkmark and shows image in combination with checkmark

Comment 6

[Tim Nguyen :ntim]

(In reply to Shane Caraveo (:mixedpuppy) from comment #5)
> Created attachment 8387171 [details]
> osxmenu.png
> 
> osx menu does have padding for checkmark and shows image in combination with
> checkmark

The Windows menu hides the icon and replaces with a checkmark when the menu item is checked

Comment 7

[Shane Caraveo (:mixedpuppy)]

This is handled in the new patch for bug 960198