978570 - (icaljs) [meta] Enable ical.js by default

Status: RESOLVED FIXED

(Calendar :: ICAL.js Integration, task, P2)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This bug should gather blocking issues that keep us from switching to ical.js by default. This mostly means issues that restrict usability, i.e performance issues or major errors. More to come

Comment 1

[Magnus Melin [:mkmelin]]

We should make this happen for 76, and drop libical shortly after.

Comment 2

[Дилян Палаузов]

Concerning https://mail.mozilla.org/pipermail/tb-planning/2020-October/008030.html, if the plan is to switch to https://github.com/mozilla-comm/ical.js/, then somebody shall tackle now the problems reported for ical.js, as this will avoid later problems within Thunderbird.

As far as I know libical is very much modified within the Thunderbird source code, compared to upstream and upstream it has very few reported problems. (Or rather, compared to its usage, the reported problems have the nature of feature requests or uncertainty of how to read RFCs). Switching to upstream libical could be also a means to increase maturity by reducing IT burden.

Comment 3

[Kai Engert (:KaiE:)]

It has been suggest to enable this by default for TB Beta, can we do this immediately? If yes, who could handle it?

Comment 4

[Kai Engert (:KaiE:)]

Is this the correct pref to enable it? calendar.icaljs

Comment 5

[Kai Engert (:KaiE:)]

I guess I found the place where this is controlled and can make a patch

Comment 6

[Kai Engert (:KaiE:)]

Attachment: Bug 978570 - enable ical.js by default. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

After landing on trunk, just request beta uplift.

Comment 8

[Kai Engert (:KaiE:)]

Please help me track checkin-needed and approval-beta when ready.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Kai Engert (:KaiE:) from comment #3)

It has been suggest to enable this by default for TB Beta, can we do this immediately? If yes, who could handle it?

I haven't seen any discussion or information on what has been tested. And what are the plans/time line surrounding enabling this. Can you add both of these to the bug report please?

Some points/questions:

1. What do we know about the size of the daily users who use calendar, and how that testing has gone?
2. Have we solicited beta users to test prior enabling it by default for all beta users? (I'm sure we have users who would be willing to test)
3. Almost no icaljs bug reports have been fixed in the past year. And almost no open bug reports have been touched in the past year, including bugs which are marked as blockers to this bug report.
4. Are there potential blocker issues at https://github.com/libical/libical/issues?
5. Do we have calendar developer(s) who are committed to immediately fixing regressions reported by beta users?
6. Why would we enable this for beta before doing Bug 1754417 - upgrade to ical.js 1.5.0?

Comment 10

[Magnus Melin [:mkmelin]]

We may have to delay getting it onto beta for a month, so we can address at least some of those bugs before that. Next merge is March 8.

Comment 11

[Kai Engert (:KaiE:)]

(In reply to Magnus Melin [:mkmelin] from comment #10)

We may have to delay getting it onto beta for a month, so we can address at least some of those bugs before that. Next merge is March 8.

Sounds like we're ready to land into c-c. If we land it now, it won't be in beta until after that date.

Comment 12

[Kai Engert (:KaiE:)]

Note that I was really just giving a helping hand with this tiny patch, I don't think this calendar meta bug should be assigned to me.

Comment 13

[Geoff Lankow (:darktrojan)]

Hmm, yeah. I'll let this be marked as fixed when it lands, and just not have an assignee.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e833a3991cb8
enable ical.js by default. r=mkmelin

Comment 15

[Geoff Lankow (:darktrojan)]

Bah, robots!