Closed Bug 978570 (icaljs) Opened 9 years ago Closed 7 months ago

[meta] Enable ical.js by default

Categories

(Calendar :: ICAL.js Integration, task, P2)

Lightning 2.6

Tracking

(thunderbird_esr91 wontfix)

RESOLVED FIXED
99 Branch
Tracking Status
thunderbird_esr91 --- wontfix

People

(Reporter: Fallen, Unassigned)

References

(Depends on 7 open bugs)

Details

(Keywords: meta)

Attachments

(1 file)

This bug should gather blocking issues that keep us from switching to ical.js by default. This mostly means issues that restrict usability, i.e performance issues or major errors. More to come
Priority: -- → P2
Depends on: 978571
Depends on: 1081534
Depends on: 1082286
Depends on: 1103187
Depends on: 1115667
Depends on: 1117456
Blocks: 700827
Depends on: 1212914
Depends on: 1179783
Depends on: 1266797
Depends on: 1411530
Keywords: meta

We should make this happen for 76, and drop libical shortly after.

Type: defect → task
Depends on: 1643701
Blocks: 1562313
Depends on: 1659582

Concerning https://mail.mozilla.org/pipermail/tb-planning/2020-October/008030.html, if the plan is to switch to https://github.com/mozilla-comm/ical.js/, then somebody shall tackle now the problems reported for ical.js, as this will avoid later problems within Thunderbird.

As far as I know libical is very much modified within the Thunderbird source code, compared to upstream and upstream it has very few reported problems. (Or rather, compared to its usage, the reported problems have the nature of feature requests or uncertainty of how to read RFCs). Switching to upstream libical could be also a means to increase maturity by reducing IT burden.

Depends on: 1736288

It has been suggest to enable this by default for TB Beta, can we do this immediately? If yes, who could handle it?

Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(vseerror)

Is this the correct pref to enable it? calendar.icaljs

I guess I found the place where this is controlled and can make a patch

Assignee: nobody → kaie
Status: NEW → ASSIGNED
Depends on: 1754412

After landing on trunk, just request beta uplift.

Flags: needinfo?(mkmelin+mozilla)
Depends on: 1754413
Depends on: 1732710

Please help me track checkin-needed and approval-beta when ready.

(In reply to Kai Engert (:KaiE:) from comment #3)

It has been suggest to enable this by default for TB Beta, can we do this immediately? If yes, who could handle it?

I haven't seen any discussion or information on what has been tested. And what are the plans/time line surrounding enabling this. Can you add both of these to the bug report please?

Some points/questions:

  1. What do we know about the size of the daily users who use calendar, and how that testing has gone?
  2. Have we solicited beta users to test prior enabling it by default for all beta users? (I'm sure we have users who would be willing to test)
  3. Almost no icaljs bug reports have been fixed in the past year. And almost no open bug reports have been touched in the past year, including bugs which are marked as blockers to this bug report.
  4. Are there potential blocker issues at https://github.com/libical/libical/issues?
  5. Do we have calendar developer(s) who are committed to immediately fixing regressions reported by beta users?
  6. Why would we enable this for beta before doing Bug 1754417 - upgrade to ical.js 1.5.0?
Flags: needinfo?(vseerror)
Assignee: kaie → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mkmelin+mozilla)

We may have to delay getting it onto beta for a month, so we can address at least some of those bugs before that. Next merge is March 8.

Flags: needinfo?(mkmelin+mozilla)
Assignee: nobody → kaie
Status: NEW → ASSIGNED

(In reply to Magnus Melin [:mkmelin] from comment #10)

We may have to delay getting it onto beta for a month, so we can address at least some of those bugs before that. Next merge is March 8.

Sounds like we're ready to land into c-c. If we land it now, it won't be in beta until after that date.

Note that I was really just giving a helping hand with this tiny patch, I don't think this calendar meta bug should be assigned to me.

Hmm, yeah. I'll let this be marked as fixed when it lands, and just not have an assignee.

Assignee: kaie → nobody
Status: ASSIGNED → NEW
Target Milestone: --- → 99 Branch
Assignee: nobody → kaie
Status: NEW → ASSIGNED

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/e833a3991cb8
enable ical.js by default. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED

Bah, robots!

Assignee: kaie → nobody
Regressions: 1790339
Regressions: 1789999
You need to log in before you can comment on or make changes to this bug.