Closed Bug 978605 Opened 11 years ago Closed 11 years ago

Crash when fullscreen & dragging item on imgur [ @ mozilla::dom::WrapNewBindingObjectHelper ]

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla30
Tracking Flags:
Tracking Status
firefox30 - verified

People

(Reporter: stevee, Assigned: smaug)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

.files can be null
769 bytes, patch
khuey
: review+
Details | Diff | Splinter Review
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140302030203 CSet: 0085a162499f 1. New profile, start firefox 2. Visit http://imgur.com/ 3. Press F11 to go fullscreen 4. At the top left of Imgur, there is the imgur icon and next to it a "random mode" icon (two arrows twisted together). Hold left mouse button on the icon and move the mouse Expected: - No crash Actual: - Crash https://crash-stats.mozilla.com/report/index/6d263c6a-da14-4557-be26-22d532140302 https://crash-stats.mozilla.com/report/index/6eae1227-a605-42d6-b680-b5b772140302 https://crash-stats.mozilla.com/report/index/29c8a99c-3549-4d67-b0b1-21e7d2140302 When you drag this icon in non-fullscreen mode it triggers some 'upload' dialog or something. But it crashes in fullscreen. No regression range, will look tomorrow if no one has beaten me to it.
Keywords: crash
Assignee: nobody → bugs
Not need fullscreen. Steps To Reproduce: 1. Start Fitrfox with new profile 2. Open http://imgur.com/ (not need sign in) 3. Click a thumbnail 4. Drag "Imgur" logo at top-left and move any of content area Actual Results: Crash bp-72b1689b-c35d-4c90-8027-275562140302 Regression window(m-i) Good: https://hg.mozilla.org/integration/mozilla-inbound/rev/26bfe4ef1bc2 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140226190714 Bad: https://hg.mozilla.org/integration/mozilla-inbound/rev/a40bcf02bb60 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140226192511 Pushlog: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=26bfe4ef1bc2&tochange=a40bcf02bb60 Regressed by:Bug 923054
status-firefox30: --- → affected
tracking-firefox30: --- → ?
Keywords: regression
Crash Signature: [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<mozilla::dom::HTMLImageElement>, int>::Wrap(JSContext*, JS::Handle<JSObject*>, nsRefPtr<mozilla::dom::HTMLImageElement> const&, JS::MutableHandle<JS::Value>)]
Attachment #8384335 - Flags: review?(khuey)
based on local (chrome js) test, the patch helps with another testcase with similar stack.
Btw, I think we should make bindings less error prone with null stuff. We've fixed this same bug too many times.
I'm adding a few very similar signatures I see in data - smaug/khuey, am I assuming right that the patch will fix all those when it lands in Nightly?
Crash Signature: [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<mozilla::dom::HTMLImageElement>, int>::Wrap(JSContext*, JS::Handle<JSObject*>, nsRefPtr<mozilla::dom::HTMLImageElement> const&, JS::MutableHandle<JS::Value>)] → [@ mozilla::dom::WrapNewBindingObjectHelper<nsRefPtr<mozilla::dom::HTMLImageElement>, int>::Wrap(JSContext*, JS::Handle<JSObject*>, nsRefPtr<mozilla::dom::HTMLImageElement> const&, JS::MutableHandle<JS::Value>)] [@ mozilla::dom::WrapNewBindingObjectHelpe…
https://hg.mozilla.org/mozilla-central/rev/ac3cee816b0b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
no crashes reported since this landed
Status: RESOLVED → VERIFIED
status-firefox30: affected → verified
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: