Closed
Bug 978620
Opened 11 years ago
Closed 11 years ago
"ASSERTION: we should have saved a frame property" with frameset
Categories
(Core :: Layout, defect, P4)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: jruderman, Assigned: dbaron)
References
Details
(Keywords: assertion, regression, testcase)
Attachments
(3 files)
###!!! ASSERTION: we should have saved a frame property: 'Not Reached', file layout/base/nsCSSRendering.cpp, line 578
David Baron added this assertion two weeks ago in bug 480888, but it's possible this is a more recent regression.
|
Reporter | |
Comment 1•11 years ago
|
||
|
Assignee | |
Comment 2•11 years ago
|
||
Ah, good, my patch made it so that we have an assertion that catches frames whose reflow methods forget to call FinishAndStoreOverflow (which leads to repainting bugs).
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
OS: Mac OS X → All
Priority: -- → P4
Hardware: x86_64 → All
|
|
Assignee | |
Comment 3•11 years ago
|
||
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #2)
> Ah, good, my patch made it so that we have an assertion that catches frames
> whose reflow methods forget to call FinishAndStoreOverflow (which leads to
> repainting bugs).
... well, at least for frame classes that call DisplayBorderBackgroundOutline in their BuildDisplayList implementation. (nsFrame doesn't.)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8384403 -
Flags: review?(roc)
Attachment #8384403 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba9b13653eee
(also see try push at https://tbpl.mozilla.org/?tree=Try&rev=657c8987d64d)
Flags: in-testsuite+
|
||
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•