978646 - Leak with expando on document.styleSheetSets

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Comment 1

[Jesse Ruderman]

Attachment: leak info

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Properly cycle-collect document.styleSheetSets.

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8384671 [details] [diff] [review]
Properly cycle-collect document.styleSheetSets.

Review of attachment 8384671 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +1899,5 @@
>    NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mDisplayDocument)
>  
>    // Traverse all nsDocument nsCOMPtrs.
>    NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mParser)
>    NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mScriptGlobalObject)

Some of these other fields, mParser and mScriptGlobalObject, don't seem to be unlinked either.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yeah, see this comment in unlink there:

  // nsDocument has a pretty complex destructor, so we're going to
  // assume that *most* cycles you actually want to break somewhere
  // else, and not unlink an awful lot here.

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de9afae6cdcc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de9afae6cdcc