Closed
Bug 978687
Opened 11 years ago
Closed 11 years ago
Pressing the 'home' button when the utility tray is opened, hide the utility tray and pan the homescreen.
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file, 1 obsolete file)
|
20.21 KB,
patch
|
etienne
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
I'm going to see with jcarpenter if this is the right behavior. I will also add a test in this case.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8384487 [details] [diff] [review]
bug978687.patch
Josh is fine with it. Let's start the review cycle on the code until I have some tests.
Attachment #8384487 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Same with tests.
Attachment #8384487 -
Attachment is obsolete: true
Attachment #8384487 -
Flags: review?(etienne)
Attachment #8384559 -
Flags: review?(etienne)
|
|
Assignee | |
Comment 4•11 years ago
|
||
I killed the fakeEvt mostly because I'm interested to not have to add the preventDefault bits again in bug 971006.
|
|
Assignee | |
Comment 5•11 years ago
|
||
And Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/19987975
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8384559 [details] [diff] [review]
bug978687.patch
Review of attachment 8384559 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, very nice unit testing :)
Attachment #8384559 -
Flags: review?(etienne) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•