978696 - [Sora][Contacts] The vCard exported from Soul 3.5 FF can not be imported into Android devices.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[sync-1]

the latest id: Mozilla build ID: 20140208004002 FFOS: 1.3
 
 DEFECT DESCRIPTION:
  The vCard exported from FFOS can not be imported into Android devices.
 
  REPRODUCING PROCEDURES: 
  Precondition: There are several contacts in the list
  1. Idle -> Contacts -> Tap "Settings" icon -> Export contacts
  2. Put the vCard exported from FFOS into Android devices
  3. Try to import the vCard into Android devices -> The vCard exported from FFOS can not be imported into Android devices-> (K.O)
 
  EXPECTED BEHAVIOUR:
  The vCard exported from FFOS can be imported into Android devices.
   
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE: 100%

Comment 1

[Jason Smith [:jsmith]]

Can you provide an example vcard that was exported from FxOS here that cannot be imported in an Android device?

Comment 2

[sync-1]

Created an attachment (id=654142)
 the vcard file exported from FxOS that cannot be imported in an Android device

Comment 3

[sync-1]

Created an attachment (id=654142)
 the vcard file exported from FxOS that cannot be imported in an Android device

Comment 4

[sync-1]

Attachment: the vcard file exported from FxOS that cannot be imported in an Android device

Created an attachment (id=654142)
 the vcard file exported from FxOS that cannot be imported in an Android device

Comment 5

[Jason Smith [:jsmith]]

Francisco - Do you know why Android is failing to import the vcard format generated from FxOS here?

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

This is looking weird. Cannot read it with android 4.4, but can do from iOS and other Mac software (like Outlook and Contacts mac app), also when installing software from the marketplace in android I can read the file as well.

I'm starting to think that perhaps is a problem with the aosp implementation.

Flaging Sergi that created the parsers to check if he has more insights.

Comment 8

[童玮]

(In reply to Francisco Jordano [:arcturus] from comment #7)
> Hi,
> 
> This is looking weird. Cannot read it with android 4.4, but can do from iOS
> and other Mac software (like Outlook and Contacts mac app), also when
> installing software from the marketplace in android I can read the file as
> well.

May I know which app  you install from the Android marketplace to read the file?

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to 童玮 from comment #8)
> (In reply to Francisco Jordano [:arcturus] from comment #7)
> > Hi,
> > 
> > This is looking weird. Cannot read it with android 4.4, but can do from iOS
> > and other Mac software (like Outlook and Contacts mac app), also when
> > installing software from the marketplace in android I can read the file as
> > well.
> 
> May I know which app  you install from the Android marketplace to read the
> file?

Hi!

I used this one:

https://play.google.com/store/apps/details?id=com.wigball.android.vcard.demo

Cheers!

Comment 10

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I'll try to test that file with the vcf parser and see. Cheers!

Comment 11

[bhavana bajaj [:bajaj]]

(In reply to Sergi Mansilla from comment #10)
> I'll try to test that file with the vcf parser and see. Cheers!

Sergi,

Any updates on the resolution or an eta here ?

Comment 12

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Looking into it right now.

Comment 13

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: 3.vcf

After doing some tests, I believe that Android 4.4 can't import vCard 4.0 format. The test has been done with the attached file, which is the absolute minimal VCF file that could exist, and it still can't parse it (attached). When switching the version to 3.0 there is no problem to import it.

Trying with the vCard files in Wikipedia, the same can be observed. vCard 4.0 is not supported in Android...which is crazy if that's the case.

Comment 14

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Last week we spoke about making a new issue reflecting the vcard export change from 4.0 to 3.0 and close this one with `WONTFIX`. Should we do that or just continue work in this current issue?

Comment 15

[Jason Smith [:jsmith]]

(In reply to Sergi Mansilla from comment #14)
> Last week we spoke about making a new issue reflecting the vcard export
> change from 4.0 to 3.0 and close this one with `WONTFIX`. Should we do that
> or just continue work in this current issue?

I don't think that makes this bug a WONTFIX. Instead, we should use this bug to track switching over to vcard 3.0 to be able to allow exported contacts from Firefox OS to work on Android.

How much work is required to implement the 3.0 support? Is it non-trivial & risky?

Comment 16

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

(In reply to Jason Smith [:jsmith] from comment #15)
> (In reply to Sergi Mansilla from comment #14)
> > Last week we spoke about making a new issue reflecting the vcard export
> > change from 4.0 to 3.0 and close this one with `WONTFIX`. Should we do that
> > or just continue work in this current issue?
> 
> I don't think that makes this bug a WONTFIX. Instead, we should use this bug
> to track switching over to vcard 3.0 to be able to allow exported contacts
> from Firefox OS to work on Android.
> 
> How much work is required to implement the 3.0 support? Is it non-trivial &
> risky?

I am working on it right now, I am at 70%. It is not hard and not very risky. I will add extra-tests to make sure, though.

Comment 17

[Joe Cheng [:jcheng] (please needinfo)]

agree with comment 15

Comment 18

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Github Pull Request

This patch changes the export format from vcard 4.0 to 3.0. It changes the least amount of code to make it work properly. Adjusted unit tests and tested import in Android 4.4, works fine but Android doesn't seem to import pictures from vCard, on purpose. Other systems have no problem seeing the pictures (tested on OSX and in-browser data-uris).

I will create a new issue for potential fixes to encoding and quoting (not relevant to this issue because if any, they will be present in previous code as well).

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8397820 [details] [review]
Github Pull Request

Codewise looking good to me.

Tried on the phone and working fine, still have that weird feeling about this is going to bite us later, not cause of our code but the different android implementations.

Thanks a lot Sergi, merge once travis is green.

Comment 20

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/c18b46b4c3f56971df5c5e2e0cba13905c0af0d2

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

Asking for VERIFYME before asking for the approval to 1.3, so we are sure we uplift safely

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Please request approval-gaia-v1.3 on this patch if it's ready for uplift to v1.3.

Comment 23

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8397820 [details] [review]
Github Pull Request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Nor regression, we have been asked to downgrade generation of vcard from 4.0 to 3.0 to be more compatible with androids, since it's the most extended version.
[User impact] if declined:
No possible interaction of our contacts db with android phones
[Testing completed]:
asked for verifyme
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 24

[bhavana bajaj [:bajaj]]

(In reply to Francisco Jordano [:arcturus] from comment #23)
> Comment on attachment 8397820 [details] [review]
> Github Pull Request
> 
> NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to
> better understand the B2G approval process and landings.
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):
> Nor regression, we have been asked to downgrade generation of vcard from 4.0
> to 3.0 to be more compatible with androids, since it's the most extended
> version.
> [User impact] if declined:
> No possible interaction of our contacts db with android phones
> [Testing completed]:
> asked for verifyme
> [Risk to taking this patch] (and alternatives if risky):
> [String changes made]:

can you help understand the risk here ? Do we have unit/integration or automation coverage in this area ?
Refer to guidelines : https://wiki.mozilla.org/Release_Management/Uplift_rules#Guidelines_on_approval_comments to see what we are looking for. Thanks !

Comment 25

[Francisco Jordano [:arcturus] [:francisco]]

We do have unit tests for this change passing, also flagged as VERIFYME to land it more confident.

Comment 26

[bhavana bajaj [:bajaj]]

(In reply to Francisco Jordano [:arcturus] from comment #25)
> We do have unit tests for this change passing, also flagged as VERIFYME to
> land it more confident.

thanks! I'll wait to approve on 1.3 till we get verification,How about the risk here ?

Comment 27

[Francisco Jordano [:arcturus] [:francisco]]

Not pretty risky since the downgrade is basically text formatting pretty similar and basically turning lots of strings to upper case.

Comment 28

[Roland Kunkel [:RolandK]]

Creating a contact on a FFOS device, I used a Buri on the latest v1.5 build. I successfully exported a contact as a vCard to the memory card. Transferring the memory card to the Android device I successfully imported the FFOS created contact. Verified as fixed Master Buri build v1.5: 

v1.5 4/3 Environmental Variables:
Device: Buri 1.5 MOZ RIL
BuildID: 20140403040201
Gaia: 0e974ff33ba47f3d1e59df1e0ad534f1bbe3ef8a
Gecko: 91be2828f17e
Version: 31.0a1
Firmware Version: V1.2-device.cfg

- 

1) Verified against Master Buri build v1.5, changing status to verified.

Comment 29

[Ryan VanderMeulen [:RyanVM]]

v1.4: https://github.com/mozilla-b2g/gaia/commit/151eefcd9b96735b765df1aa93fcb5b9984d2e43
v1.3: https://github.com/mozilla-b2g/gaia/commit/ef98fa5764d68ebdbcc4c575d6cab8c61f9ef5cf