978729 - hg mv margin-collapsing tests from test-0 to test-0a if test-0b, -0c, ... exist

Status: NEW

(Core :: Layout: Block and Inline, enhancement, P5)

Description

[Daniel.S]

In bug 921761, the margin collapsing test suite was not only extended but a small flaw was introduced as well.

The tests block-no-content-3 and -4 now have similar tests called block-no-content-3b and -4c. The original tests should be called block-no-content-3a and -4a using hg mv

It is possible that more tests with this flaw will be added later, so this is a clean-up bug that should get fixed when bug 477462 is finished.

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel.S from comment #0)
> The tests block-no-content-3 and -4 now have similar tests called
> block-no-content-3b and -4c

Note: technically, mozilla-central only has "-3" and "-4" -- there aren't any b/c variants of either test yet. Those variants are only created in your latest patch (wave 8 / wave 8 rev 1, on bug 477462), which has not yet landed.

My preference would be for this rename to just happen as a part of that patch. You should be able to just apply that patch (with mercurial queues), run the "hg mv" command, and then hg qref to update the patch.

(I'll note that over there, too; just posting here to give you a heads up, since I'm only partway through the review over there.)

(This bug here may still have some value for fixing any other tests that slip through the review-cracks and end up needing a rename.)

Comment 2

[Daniel Holbert [:dholbert]]

Oh, I guess I did say "however, that doesn't necessarily have to happen here" in the other bug. Sorry for the mixed messages. :) I think I probably said that because I was suggesting so much additional work at the same time (all of the 'hg cp' consolidation).

Anyway -- I do think it's probably best to do the rename as part of the same patch that creates the need for the rename, if you don't mind. (Shouldn't be much trouble; just four hg mv commands [for -3, -3-dyn, -4, -4-dyn] and a reftest.list tweak)