Closed
Bug 978851
Opened 11 years ago
Closed 11 years ago
LoadInfo::UpdateSystemLoad warns about format string in sscanf
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: padenot, Assigned: gcp)
Details
Attachments
(1 file, 3 obsolete files)
|
1.38 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
LoadInfo::UpdateSystemLoad warns about format string error.
|
Reporter | |
Comment 1•11 years ago
|
||
This fixes it locally.
Attachment #8384706 -
Flags: review?(gpascutto)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Summary: Bug XXXXXX - Fix sscanf warning in LoadMonitor.cpp. r= → LoadInfo::UpdateSystemLoad warns about format string in sscanf
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8384706 [details] [diff] [review]
Bug XXXXXX - Fix sscanf warning in LoadMonitor.cpp. r=
Review of attachment 8384706 [details] [diff] [review]:
-----------------------------------------------------------------
This is broken as the counters are 64-bit. We'd better use this:
http://stackoverflow.com/questions/6993132/format-specifiers-for-uint8-t-uint16-t
Attachment #8384706 -
Flags: review?(gpascutto) → review-
|
|
Reporter | |
Comment 4•11 years ago
|
||
This appears to work.
Attachment #8385226 -
Flags: review?(gpascutto)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8384706 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8385226 -
Flags: review?(gpascutto) → review+
|
|
Reporter | |
Comment 5•11 years ago
|
||
This should work on Windows.
Attachment #8385264 -
Flags: review?(gpascutto)
|
|
Reporter | |
Updated•11 years ago
|
Attachment #8385226 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8385264 [details] [diff] [review]
Fix sscanf warning in LoadMonitor.cpp. r=
Review of attachment 8385264 [details] [diff] [review]:
-----------------------------------------------------------------
Reading the header says that the scanf macros aren't actually supported on Windows. Looks like we have to read in those via something else than sscanf.
Attachment #8385264 -
Flags: review?(gpascutto) → review-
|
|
Assignee | |
Comment 7•11 years ago
|
||
Assignee: paul → gpascutto
Attachment #8385264 -
Attachment is obsolete: true
Attachment #8385385 -
Flags: review?(paul)
|
|
Reporter | |
Comment 8•11 years ago
|
||
Comment on attachment 8385385 [details] [diff] [review]
Patch 1. fix-sscanf-warning in LoadMonitor.cpp
Review of attachment 8385385 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/media/webrtc/LoadMonitor.cpp
@@ +219,2 @@
> &user, &nice,
> &system, &idle) != 4) {
nit: the indentation is now slightly off.
Attachment #8385385 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
|
||
Comment 10•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•