978860 - document.domain breaks texImage2D

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[[e-mail]]

Attachment: test_webgl_xorigin.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20140212131424

Steps to reproduce:

Run this HTML on test.mydomain.com on Firefox 27.0.1 on Mac OS X.

<canvas id="C"></canvas>
<script>
    document.domain = 'mydomain.com';
    var T = new Image;
    T.onload = function(){
        var gl = C.getContext('webgl');
        var t = gl.createTexture();
        gl.bindTexture(gl.TEXTURE_2D, t);
        gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, T);
        console.log('PASS');
    };
    T.src = 'test_webgl_xorigin.jpg';
</script>


Actual results:

19:24:09.586 Error: WebGL: It is forbidden to load a WebGL texture from a cross-domain element that has not been validated with CORS. See https://developer.mozilla.org/en/WebGL/Cross-Domain_Textures

19:24:09.586 SecurityError: The operation is insecure.


Expected results:

PASS printed to the console. If "document.domain = 'mydomain.com'" line is commented out, PASS is printed as expected.

Comment 1

[[e-mail]]

It seems similar to https://bugzilla.mozilla.org/show_bug.cgi?id=567511

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This Subsumes(): http://dxr.mozilla.org/mozilla-central/source/content/canvas/src/WebGLContextGL.cpp?from=WebGLContextGL.cpp&case=true#2619 should likely be SubsumesIgnoringDomain, as per the patch for bug 567511.

Comment 3

[Anne (:annevk)]

Normal origin checks should happen, it's just that effective script origin should not be used here.

Comment 4

[Anne (:annevk)]

Per bz bug 956382 fixed this. Might be good to check in a test.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Denis, is this still a problem in Firefox 30 for you?

Comment 6

[[e-mail]]

Boris, it seems that the test case passes in Firefox 30. Thanks, should be OK to close.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Resolving WORKSFORME based on comment 6.

Comment 8

[Boris Zbarsky [:bzbarsky]]

We know what fixed this.  ;)

Denis, thanks for the quick response!