979232 - Bookmarking animation goes the wrong way in RTL mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

What it says in the summary. It looks a bit silly, having the star move from the menu dropmarker to the star...

Comment 1

[:Gijs (he/him)]

Attachment: adjust Australis' bookmarks animation for rtl,

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8385306 [details] [diff] [review]
adjust Australis' bookmarks animation for rtl,

>+      let isRTL = getComputedStyle(this.button).direction == "rtl";
>       let buttonRect = this.button.getBoundingClientRect();
>       let notifierRect = this.notifier.getBoundingClientRect();
>       let topDiff = buttonRect.top - notifierRect.top;
>       let leftDiff = buttonRect.left - notifierRect.left;
>       let heightDiff = buttonRect.height - notifierRect.height;
>       let widthDiff = buttonRect.width - notifierRect.width;
>       let translateX = (leftDiff + .5 * widthDiff) + "px";
>       let translateY = (topDiff + .5 * heightDiff) + "px";
>-      this.notifier.style.transform = "translate(" +  translateX + ", " + translateY + ")";
>+      let desiredTransform = "translate(" +  translateX + ", " + translateY + ")";
>+      if (isRTL) {
>+        desiredTransform += " scaleX(-1)";
>+      }
>+      this.notifier.style.transform = desiredTransform;

s/desiredTransform/transform/

Comment 3

[:Gijs (he/him)]

w/ nit,

remote:   https://hg.mozilla.org/integration/fx-team/rev/b45d126adc15

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b45d126adc15

Comment 5

[:Gijs (he/him)]

Comment on attachment 8385306 [details] [diff] [review]
adjust Australis' bookmarks animation for rtl,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: RTL users have the bookmark animation going the wrong way (from dropmarker to star instead of vice versa)
Testing completed (on m-c, etc.): on m-c, locally
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bdaacace9232

Comment 7

[Cornel Ionce [:noni] [Hubs QA]]

Verified as fixed on latest Nightly (build ID: 20140313030202) and latest Aurora (build ID: 20140313004000).
Tested on Windows 7 64 bit, Ubuntu 12.04 and Mac OS X 10.9.
- verified using the "He", "Ar" and "Fa" locales
- verified by creating the string preference "intl.uidirection.en" and set it the value "rtl".