Last Comment Bug 979232 - Bookmarking animation goes the wrong way in RTL mode
: Bookmarking animation goes the wrong way in RTL mode
Status: VERIFIED FIXED
[Australis:P3]
: rtl
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All All
-- normal (vote)
: Firefox 30
Assigned To: :Gijs
: Cornel Ionce [QA] (:cornel_ionce)
: Dão Gottwald [:dao]
Mentors:
Depends on:
Blocks: australis-cust 931343
  Show dependency treegraph
 
Reported: 2014-03-04 03:55 PST by :Gijs
Modified: 2014-03-14 02:43 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
verified
verified


Attachments
adjust Australis' bookmarks animation for rtl, (2.05 KB, patch)
2014-03-04 06:18 PST, :Gijs
dao+bmo: review+
sledru: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image :Gijs 2014-03-04 03:55:18 PST
What it says in the summary. It looks a bit silly, having the star move from the menu dropmarker to the star...
Comment 1 User image :Gijs 2014-03-04 06:18:42 PST
Created attachment 8385306 [details] [diff] [review]
adjust Australis' bookmarks animation for rtl,
Comment 2 User image Dão Gottwald [:dao] 2014-03-04 08:51:15 PST
Comment on attachment 8385306 [details] [diff] [review]
adjust Australis' bookmarks animation for rtl,

>+      let isRTL = getComputedStyle(this.button).direction == "rtl";
>       let buttonRect = this.button.getBoundingClientRect();
>       let notifierRect = this.notifier.getBoundingClientRect();
>       let topDiff = buttonRect.top - notifierRect.top;
>       let leftDiff = buttonRect.left - notifierRect.left;
>       let heightDiff = buttonRect.height - notifierRect.height;
>       let widthDiff = buttonRect.width - notifierRect.width;
>       let translateX = (leftDiff + .5 * widthDiff) + "px";
>       let translateY = (topDiff + .5 * heightDiff) + "px";
>-      this.notifier.style.transform = "translate(" +  translateX + ", " + translateY + ")";
>+      let desiredTransform = "translate(" +  translateX + ", " + translateY + ")";
>+      if (isRTL) {
>+        desiredTransform += " scaleX(-1)";
>+      }
>+      this.notifier.style.transform = desiredTransform;

s/desiredTransform/transform/
Comment 3 User image :Gijs 2014-03-04 09:55:38 PST
w/ nit,

remote:   https://hg.mozilla.org/integration/fx-team/rev/b45d126adc15
Comment 4 User image Ryan VanderMeulen [:RyanVM] 2014-03-04 13:26:58 PST
https://hg.mozilla.org/mozilla-central/rev/b45d126adc15
Comment 5 User image :Gijs 2014-03-04 14:34:16 PST
Comment on attachment 8385306 [details] [diff] [review]
adjust Australis' bookmarks animation for rtl,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: RTL users have the bookmark animation going the wrong way (from dropmarker to star instead of vice versa)
Testing completed (on m-c, etc.): on m-c, locally
Risk to taking this patch (and alternatives if risky): very low
String or IDL/UUID changes made by this patch: none
Comment 7 User image Cornel Ionce [QA] (:cornel_ionce) 2014-03-14 02:43:34 PDT
Verified as fixed on latest Nightly (build ID: 20140313030202) and latest Aurora (build ID: 20140313004000).
Tested on Windows 7 64 bit, Ubuntu 12.04 and Mac OS X 10.9.
- verified using the "He", "Ar" and "Fa" locales
- verified by creating the string preference "intl.uidirection.en" and set it the value "rtl".

Note You need to log in before you can comment on or make changes to this bug.