979234 - [Camera] [Madai] Fix integration tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Diego Marcos [:dmarcos]]

The commit below broke the integration tests:

Bug 974119 - [Camera][Madai] 1.4 Viewfinder size and alignment

Comment 1

[Diego Marcos [:dmarcos]]

Attachment: Link to dumb for investigation

Comment 2

[Diego Marcos [:dmarcos]]

I need a second pair of eyes here. I still don't understand what's going on. I attach a dumb patch that fixes the issue just for investigation purposes. Python marionnette is still opaque to me.

Comment 3

[Diego Marcos [:dmarcos]]

Attachment: Link to dumb patch for investigation purposes

Comment 4

[Diego Marcos [:dmarcos]]

Attachment: Link to dumb patch for investigation purposes

Comment 5

[Diego Marcos [:dmarcos]]

Attachment: Link to dumb patch for investigation purposes

Comment 6

[Justin D'Arcangelo [:justindarc]]

In my opinion, the test should be fixed to recognize the updated DOM, not the other way around. To do that, the CSS selectors at the top of this file need to be fixed:

https://github.com/dmarcos/gaia/blob/508a9d8057c09394ee3f6ecba5b554119eb3ebda/tests/python/gaia-ui-tests/gaiatest/apps/camera/app.py

Comment 7

[Diego Marcos [:dmarcos]]

The patch is not meant to fix the issue is just an exercise to understand what's going on. I don't understand why with the old DOM the integration tests break and with the DOM in the patch the tests pass. It doesn't make any sense to me. I already spent too much time and I'm asking for help to diagnose the issue

Comment 8

[Justin D'Arcangelo [:justindarc]]

Its because the tests (in app.py in my previous comment) use the CSS selectors `.test-gallery`, `.test-capture`, and `.test-switch`. Without your patch, those 3 buttons no longer have those CSS classes and therefore the Python tests cannot find them.

Comment 9

[Diego Marcos [:dmarcos]]

It's not only the CSS selectors. Try the patch removing the changes in the view/viewfinder.js and see

Comment 10

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 11

[Diego Marcos [:dmarcos]]

Landed in camera dev

Comment 12

[Diego Marcos [:dmarcos]]

Attachment: pull-request (camera-new-features)

Comment 13

[David Flanagan [:djf]]

Comment on attachment 8385851 [details] [review]
pull-request (camera-new-features)

The integration test changes look good to me.  Assuming they all pass, please land.

Comment 14

[David Flanagan [:djf]]

I believe that Diego will land the integration tests changes as part of the "mega patch" in bug 980599.

Comment 15

[Diego Marcos [:dmarcos]]

Landed in camera new features as part of bug 980599

https://github.com/mozilla-b2g/gaia/commit/cab07100493b2b2970eaa61f9460a5375996e122