979248 - Fix default timeout in start_b2g

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

The default timeout is in milliseconds whereas the Wait in the method takes seconds.

Need to change the default to seconds inline iwth the rest of the suite and then email npb/rwood to let them know.

Comment 1

[Zac C (:zac)]

nbp and rwood, we have to change the default here because it's mismatched with the actual wait.

If you're passing in a timeout to start_b2g then this change will affect you at the next gaiatest release.

Can you acknowlege this? Cheers.

Comment 2

[Zac C (:zac)]

Attachment: github pr

Comment 3

[Nicolas B. Pierron [:nbp]]

ack=me.

I do not think this is going to cause any trouble in the automation that I have, I will reply back here if I see anything after the landing of the pull request in gaia-master.

Comment 4

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/b611f37534aaf27f13913f32671d38595e5256ce

Comment 5

[Robert Wood [:rwood]]

Looks like this was merged already before I could provide feedback, sorry for not commenting earlier.

Was the Wait function changed recently from MS to S? Previously with the default of 60000, b2g_start was timing out when starting up the emulator after populating large amount of data; that's why the option to override this was added to b2gpopulate. Also I'm sure during testing the new --start-timeout b2gpopulate option, it worked fine sending in MS.

If Wait has been changed to S, this won't break my automation as I am sending in a value / not using the default. However, this will require a change to b2gpopulate because b2gpopulate sends the --start-timeout override value to start_b2g in MS, not S.

Comment 6

[Zac C (:zac)]

Rob, yes the Wait was changed (to a Wait method that only takes seconds) without changing this default value (my mistake) so this was already broken before this change was committed.

So basically this won't affect anything really, but we ni? you guys to make sure we can put all the usages in alignment.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Here's the line that will need to change: https://github.com/mozilla/b2gpopulate/blob/fe4c914195391b18346c18dc907f448f44816bb3/b2gpopulate/b2gpopulate.py#L347

I'll raise a bug and get this patched.

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Robert Wood [:rwood] from comment #5)
> this won't break my automation as I am sending in a value / not using the default.

This will have the effect of multiplying your value by 1000, effectively not allowing it to timeout within a reasonable time. Once I have fixed b2gpopulate and released a new version I would recommend upgrading.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

See bug 980265.