979289 - [Camera] Make settings menu fullscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Comment 1

[Wilson Page [:wilsonpage]]

Attachment: pull-request (camera-new-features)

Comment 2

[Wilson Page [:wilsonpage]]

Landed in dmarcos/camera-dev-rebased

Comment 3

[David Flanagan [:djf]]

Comment on attachment 8385392 [details] [review]
pull-request (camera-new-features)

See comments at https://github.com/wilsonpage/gaia/commit/318a233c34f045c4a0cf209d7fb8e6e0d4e27b62#diff-346941ab7eae862405cd021818c7f05eR69

A couple of l10n-related nits is the main thing in those comments.

This seems like a general CSS cleanup patch. I don't really see how it fits under the description "make settings menu fullscreen".

I don't like touching more than one feature per patch, it doesn't seem feasible to break this up into various small patches.

Comment 4

[Wilson Page [:wilsonpage]]

Landed on 'camera-new-features': https://github.com/mozilla-b2g/gaia/commit/7093108e461c31f5bb737ed579f52373b514f29a

Comment 5

[David Flanagan [:djf]]

Bulk edit for camera bugs.

If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.

This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530