The default bug view has changed. See this FAQ.

Main menubutton separator is on the wrong side in rtl mode

RESOLVED FIXED in Firefox 29

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 1 bug, {rtl})

unspecified
Firefox 30
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox29 fixed, firefox30 fixed)

Details

(Whiteboard: [Australis:P3][good first verify])

Attachments

(1 attachment)

Comment hidden (empty)
Depends on: 909349
(Assignee)

Comment 1

3 years ago
Created attachment 8385349 [details] [diff] [review]
fix separator background position for Australis' menu panel button,
Attachment #8385349 - Flags: review?(mdeboer)
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8385349 [details] [diff] [review]
fix separator background position for Australis' menu panel button,

Review of attachment 8385349 [details] [diff] [review]:
-----------------------------------------------------------------

Nice & clean!
Attachment #8385349 - Flags: review?(mdeboer) → review+
(Assignee)

Comment 3

3 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/1cd60fd54c7a
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1cd60fd54c7a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 30
(Assignee)

Comment 5

3 years ago
Comment on attachment 8385349 [details] [diff] [review]
fix separator background position for Australis' menu panel button,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: RTL users have their main menu button "border" in the wrong place
Testing completed (on m-c, etc.): on m-c, locally
Risk to taking this patch (and alternatives if risky): none
String or IDL/UUID changes made by this patch: none
Attachment #8385349 - Flags: approval-mozilla-aurora?
status-firefox29: --- → affected
status-firefox30: --- → fixed
Attachment #8385349 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/c48879d0c178
status-firefox29: affected → fixed

Updated

3 years ago
Whiteboard: [Australis:P3] → [Australis:P3][good first verify]
You need to log in before you can comment on or make changes to this bug.