Closed Bug 979300 Opened 11 years ago Closed 11 years ago

Main menubutton separator is on the wrong side in rtl mode

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 30
Tracking Flags:
Tracking Status
firefox29 --- fixed
firefox30 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: rtl, Whiteboard: [Australis:P3][good first verify])

Attachments

(1 file)

fix separator background position for Australis' menu panel button,
1.64 KB, patch
mikedeboer
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review
No description provided.
Depends on: 909349
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8385349 [details] [diff] [review] fix separator background position for Australis' menu panel button, Review of attachment 8385349 [details] [diff] [review]: ----------------------------------------------------------------- Nice & clean!
Attachment #8385349 - Flags: review?(mdeboer) → review+
remote: https://hg.mozilla.org/integration/fx-team/rev/1cd60fd54c7a
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1cd60fd54c7a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 30
Comment on attachment 8385349 [details] [diff] [review] fix separator background position for Australis' menu panel button, [Approval Request Comment] Bug caused by (feature/regressing bug #): Australis User impact if declined: RTL users have their main menu button "border" in the wrong place Testing completed (on m-c, etc.): on m-c, locally Risk to taking this patch (and alternatives if risky): none String or IDL/UUID changes made by this patch: none
Attachment #8385349 - Flags: approval-mozilla-aurora?
Attachment #8385349 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [Australis:P3] → [Australis:P3][good first verify]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: