Closed
Bug 979326
Opened 11 years ago
Closed 11 years ago
Tweak timing for customization mode transition
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 30
People
(Reporter: phlsa, Assigned: phlsa)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
885 bytes,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
After playing around with the customization transition for a bit, I think we can make the transition feel smoother by slightly adjusting the timing.
Here's the code that works really well:
/* Customize mode */
#navigator-toolbox,
#content-deck {
transition-property: margin-left, margin-right;
transition-duration: 200ms;
transition-timing-function: linear;
}
Comment 1•11 years ago
|
||
If you're comfortable putting together a patch, I'm comfortable reviewing and landing it. Let me know if that works for you, phlsa!
Flags: needinfo?(philipp)
Assignee | ||
Comment 2•11 years ago
|
||
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Flags: needinfo?(philipp)
Assignee | ||
Updated•11 years ago
|
Attachment #8385376 -
Flags: review?(mconley)
Comment 3•11 years ago
|
||
Comment on attachment 8385376 [details] [diff] [review]
Patch v1
Review of attachment 8385376 [details] [diff] [review]:
-----------------------------------------------------------------
If UX is happy with it, then so am I. Thanks phlsa! I'll land this patch for you.
Attachment #8385376 -
Flags: review?(mconley) → review+
Comment 4•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Updated•11 years ago
|
QA Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•