979339 - [about_memory] get_about_memory script is failing with hamachi master device

Status: RESOLVED INVALID

(Firefox OS Graveyard :: General, defect)

Description

[Robert Wood [:rwood]]

Attempt to get memory dump with the latest get_about_memory.py script, from a hamachi device running master (1.4.0.0-prerelease  git commit 2014-03-03 10:34:58 dfae3744), and it fails with this error:

rwood@ubuntu:~/B2G/tools$ python get_about_memory.py 
Got 4/5 files.
We've waited 120s but the only relevant files we see are
Traceback (most recent call last):
  File "get_about_memory.py", line 291, in <module>
    get_and_show_info(args)
  File "get_about_memory.py", line 184, in get_and_show_info
    (out_dir, merged_reports_path, dmd_files) = get_dumps(args)
  File "get_about_memory.py", line 181, in get_dumps
    return utils.run_and_delete_dir_on_exception(do_work, out_dir)
  File "/home/rwood/B2G/tools/include/device_utils.py", line 147, in run_and_delete_dir_on_exception
    return fun()
  File "get_about_memory.py", line 164, in do_work
    optional_outfiles_prefixes=['dmd-'])
  File "/home/rwood/B2G/tools/include/device_utils.py", line 260, in notify_and_pull_files
    print('\n'.join(['  ' + f for f in new_files + new_unified_files]))
TypeError: unsupported operand type(s) for +: 'set' and 'set'

Comment 1

[Jason Smith [:jsmith]]

Can we get a regression range on this? When is the last time this worked? When is the first time it failed?

Comment 2

[[:fabrice] Fabrice Desré]

Did you export the MOZ_IGNORE_NUWA_PROCESS environment variable before running get_about_memory.py ?
We should make that the default now that nuwa is enabled on all devices.

Comment 3

[Robert Wood [:rwood]]

Ugh I completely forgot about that, sorry yes that was the problem. Thanks :fabrice!

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

(In reply to Fabrice Desré [:fabrice] from comment #2)
> Did you export the MOZ_IGNORE_NUWA_PROCESS environment variable before
> running get_about_memory.py ?
> We should make that the default now that nuwa is enabled on all devices.

I asked :khuey about this — the reason it's an env var instead of autodetected is that we hope to someday be able to get memory reports from the Nuwa process, so this is just a temporary workaround until that happens.  But I don't know if there's a bug for that yet, or what its number is.