Closed
Bug 979406
Opened 11 years ago
Closed 11 years ago
Don't wait 600ms before vibrating when receiving a call
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed)
RESOLVED
FIXED
| blocking-b2g | 1.3T+ |
People
(Reporter: etienne, Assigned: etienne)
References
Details
Attachments
(2 files)
The setInterval is killing us :)
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8385431 -
Flags: review?(anthony)
|
|
Assignee | |
Comment 2•11 years ago
|
||
This patch has a big ROI, so asking 1.3T?
It's only for the vibration, but we're still alerting the user of the call 600ms+ earlier, with very little risk.
blocking-b2g: --- → 1.3T?
|
||
Updated•11 years ago
|
blocking-b2g: 1.3T? → 1.3T+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8385431 [details] [review]
Gaia PR
That's how you speed up an action. By doing it earlier :)
Attachment #8385431 -
Flags: review?(anthony) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 5•11 years ago
|
||
Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks
status-b2g-v1.3T:
--- → ?
Flags: needinfo?(ying.xu)
Hi,(:etienne)
Could you please rebase your patch with 1.3t?
Seems calls_handler_test.js is very different between master and v1.3t
Flags: needinfo?(etienne)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Here's a v1.13t pull request.
Not sure what the process is after that :)
Flags: needinfo?(etienne)
Flags: needinfo?(ying.xu)
|
|
||
Comment 9•11 years ago
|
||
|
||
Updated•11 years ago
|
status-b2g-v1.4:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•