Closed Bug 979406 Opened 6 years ago Closed 6 years ago

Don't wait 600ms before vibrating when receiving a call

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: etienne, Assigned: etienne)

References

Details

Attachments

(2 files)

The setInterval is killing us :)
Assignee: nobody → etienne
Blocks: 973596
Attached file Gaia PR
Attachment #8385431 - Flags: review?(anthony)
This patch has a big ROI, so asking 1.3T?

It's only for the vibration, but we're still alerting the user of the call 600ms+ earlier, with very little risk.
blocking-b2g: --- → 1.3T?
blocking-b2g: 1.3T? → 1.3T+
Comment on attachment 8385431 [details] [review]
Gaia PR

That's how you speed up an action. By doing it earlier :)
Attachment #8385431 - Flags: review?(anthony) → review+
https://github.com/mozilla-b2g/gaia/commit/8700a2499f2a691b49b3a047dc20e25d3f105531
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Hi Ying Xu, heard that you will be doing uplifts to 1.3T branch. After you completed the uplift, can you please set status-b2g-v1.3T to fixed? please let us know if you have problems with it. thanks
Flags: needinfo?(ying.xu)
Hi,(:etienne)

Could you please rebase your patch with 1.3t?

Seems calls_handler_test.js is very different between master and v1.3t
Flags: needinfo?(etienne)
Here's a v1.13t pull request.
Not sure what the process is after that :)
Flags: needinfo?(etienne)
You need to log in before you can comment on or make changes to this bug.