979457 - [camera] "ready to use" perf measurement

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

Description

[Hubert Figuiere [:hub]]

Apparently all the work from bug 837672 is gone. We need to redo it.

Comment 1

[Hubert Figuiere [:hub]]

Also we need to address bug 971771 first.

Comment 2

[Hubert Figuiere [:hub]]

See the original pull request: https://github.com/mozilla-b2g/gaia/pull/10142/files

Comment 3

[Mike Lee [:mlee]]

Adding description from original bug 837672 referenced in comment 0:

We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive.

The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar.

For the Camera, it should be triggered when a camera preview is displayed.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Mike Lee [:mlee] from comment #3)
> 
> For the Camera, it should be triggered when a camera preview is displayed.

Since the preview being ready is a pre-condition for enabling the controls in the UI, it's probably better to post this event when the UI is ready.

Comment 5

[Wilson Page [:wilsonpage]]

We have an app event now called 'criticalpathdone'. You can hook in some perf hooks like:

app.once('criticalpathdone', perfCallback);

Do you want me to implement this?

Comment 6

[Wilson Page [:wilsonpage]]

We have an app event now called 'criticalpathdone'. You can hook in some perf hooks like:

app.once('criticalpathdone', perfCallback);

I can re-implement this into the new camera architecture. Do you need all the same calls from this initial pull-request, or just 'startup-path-done'?

Comment 7

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 8

[Hubert Figuiere [:hub]]

Comment on attachment 8422531 [details] [review]
pull-request (master)

Sorry for the delay. This patch needs a bit more work. As I said on github:

It won't run for the simple reason that you need to whitelist camera in tests/performance/startup_events_test.js.

Comment 9

[Hubert Figuiere [:hub]]

Also bug 971771 needs to be fixed first as camera is on the blacklist.

Comment 10

[Wilson Page [:wilsonpage]]

Comment on attachment 8422531 [details] [review]
pull-request (master)

- Changed all references to `PerformanceTestingHelper`
- Added 'camera' to whitelist

Comment 11

[Hubert Figuiere [:hub]]

Comment on attachment 8422531 [details] [review]
pull-request (master)

Now that bug 971771 has landed, this also works. 

Thanks !

Comment 12

[Wilson Page [:wilsonpage]]

Landed on 'master' https://github.com/mozilla-b2g/gaia/commit/d7ee97864bf2779207b19868bc08012724e75463