979492 - [B2G][Clock][Timer]Missing titles in sound selection list for timer.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: List of timer sounds.png

The user can choose what sound the device will play when a timer triggers. The titles are missing for all of the sound files except for 'No Sound'. See attached screenshot.

Repro Steps:
1) Updated Buri to BuildID: 20140304040200
2) Launch clock application.
3) Navigate to 'Timer' page.
4) Tap on 'Sound:' droplist.

Actual:
All of the sound files display empty space instead of text.

Expected:
Sound file titles are displayed.

Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140304040200
Gaia: 6df4533f14ec2645bb13d8a803a5151583ca13a8
Gecko: 529b86b92b1d
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: screenshot

Comment 1

[Marcus Cavanaugh [:mcav]]

I saw this as well, I have a patch in another branch. Will pull in shortly.

Comment 2

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16858

This was caused by the Timer panel being untranslated. Unit test covers the fix.

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8385566 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16858

changes are minimal. confirmed that it fixes the bug.

Comment 4

[Marcus Cavanaugh [:mcav]]

Thanks! Landed in master:

https://github.com/mozilla-b2g/gaia/commit/f786a9ac6f4118421055753eb867727d9aa657a0

Comment 6

[Edward Chen[:edchen]]

[Environment]
Gaia      6c109df47006b08c082761c0ddd6ba53a864983a
Gecko     https://hg.mozilla.org/mozilla-central/rev/21f293fc8d34
BuildID   20140309160201
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013


[Result]
PASS

The bug fixed, I marked it to "Verified".