979534 - Capture avatars and Webmaker IDs for organizers when creating an event

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[inactivate account for kate]

We should capture the avatar from the user object when a user creates an event so we can show it on the details page.

We might want to consider capturing other data too, like real name (if it exists)

Comment 1

[Gavin Suntop [:gvn]]

Instead of capturing avatar and real name through the add event form, can it be pulled from a service?

It seems weird to tie user metadata beyond an identifier to an event object. This should be a "join".

Comment 2

[Gavin Suntop [:gvn]]

So, just to further clarify...I mean we'd ideally pull user metadata based on email as a key/ID when the event detail page is shown. This will ensure that the user's current info will always show instead of potentially caching an outdated avatar/realname with the event data.

Comment 3

[inactivate account for kate]

We can't do a join because user data and events data are on different servers.

Say we have a list of 15 events and we want to display avatars for each of them, we'd have to make 15 http requests to the server. 

If we capture additional data from the user object while we have it on the session and store it with the event we won't have to do that.

Avatars are dynamic from gravatar anyway, so there would be no updating

Comment 4

[Cassie McDaniel [:cassiemc]]

We discussed capturing real names in bug 963271 and unless there is a good reason that raises new use cases from that previous bug, let's not do that.

Comment 5

[Gavin Suntop [:gvn]]

We're showing avatars on the event detail page, which only shows 1 event so only would need 1 additional request.

However, if it is a URL to a dynamic image asset then I agree it's not a huge deal to store that on the event object.

I'm ok with not capturing real names. I guess people can put their name in the description if they choose.

Comment 6

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker-events-service/pull/7

Comment 7

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker-events-2/pull/34

Comment 8

[Gavin Suntop [:gvn]]

Comment on attachment 8389341 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/7

I'm concerned with storing Gravatar URLs in the DB. If Gravatar ever changes their URL scheme all of our avatar imgs will break.

I'd propose doing the Gravatar URL construction on the client for this reason, especially since it's generated from another stored field (organizer).

This way if Gravatar changes their scheme or we change avatar hosting we only have to change code in one place and not have to update every record in our DB.

Comment 9

[inactivate account for kate]

Comment on attachment 8389341 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/7

Sorry let me clarify - this actually doesn't create the entry in the DB, it just adds a getter with a custom function to the model.

That way it will always return the avatar link with any call to the service (from anywhere, say if we want the data on webmaker.org), but we can remove it/change it at any time. Nothing actually gets sent or changed in the mysql database

Comment 10

[Gavin Suntop [:gvn]]

Comment on attachment 8389341 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/7

Ah, perfect then!