Closed Bug 979557 Opened 10 years ago Closed 10 years ago

CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(1 file)

This shouldn't behave differently depending on whether or not logging is
enabled; that difference was introduced in bug 785648.
Comment on attachment 8385606 [details] [diff] [review]
CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled

Review of attachment 8385606 [details] [diff] [review]:
-----------------------------------------------------------------

Hrm, I wonder if I ever ran into this...
Attachment #8385606 - Flags: review?(dzbarsky) → review+
I think there's no effect, because nsLayoutUtils::AreAsyncAnimationsEnabled() will also check gfxPlatform::OffMainThreadCompositingEnabled.  But it's still a bad pattern to have, since there's no guarantee that it'll continue having no effect in the future, and it's a bad pattern for somebody to copy.
https://hg.mozilla.org/mozilla-central/rev/63f04e426fda
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.