Closed
Bug 979557
Opened 11 years ago
Closed 11 years ago
CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
This shouldn't behave differently depending on whether or not logging is
enabled; that difference was introduced in bug 785648.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8385606 -
Flags: review?(dzbarsky)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8385606 [details] [diff] [review]
CanAnimatePropertyOnCompositor should return early when there's no OMT compositing, whether or not logging is enabled
Review of attachment 8385606 [details] [diff] [review]:
-----------------------------------------------------------------
Hrm, I wonder if I ever ran into this...
Attachment #8385606 -
Flags: review?(dzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
I think there's no effect, because nsLayoutUtils::AreAsyncAnimationsEnabled() will also check gfxPlatform::OffMainThreadCompositingEnabled. But it's still a bad pattern to have, since there's no guarantee that it'll continue having no effect in the future, and it's a bad pattern for somebody to copy.
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•