nav-bar bottom border disappears when menubar is shown temporarily (when hitting Alt) with Direct2D disabled

NEW
Unassigned

Status

()

Core
Graphics
3 years ago
9 months ago

People

(Reporter: merfius, Unassigned)

Tracking

(Blocks: 1 bug, {regression})

26 Branch
x86_64
Windows 7
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P-][gfx-noted])

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140303030201

Steps to reproduce:

before: http://i.imgur.com/bGIgZ15.png


Actual results:

hit alt: http://i.imgur.com/xqC69l2.png

Comment 1

3 years ago
Can you provide more detailed STR starting from a clean profile? We're unable to reproduce with a clean profile. :-(
Blocks: 872617
Flags: needinfo?(aeidein)
(Reporter)

Comment 2

3 years ago
It's the same STR.  Just hit Alt.

Clean profile:
http://i.imgur.com/qGfoWgo.png

Hit Alt:
http://i.imgur.com/1f3riun.png
Note that the navbar bottom border disappears.
Flags: needinfo?(aeidein)
(Reporter)

Comment 3

3 years ago
Someone mentioned that they experienced the same problem, but only when the window was maximized.

Comment 4

3 years ago
(In reply to merfius from comment #3)
> Someone mentioned that they experienced the same problem, but only when the
> window was maximized.

I can reproduce if set DPI other than 100% from Control Panel > Display. 

Depend on the dpi,
bottom border disappear, become thicker.

https://hg.mozilla.org/mozilla-central/rev/529b86b92b1d
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140304030204
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 5

3 years ago
Please IGNORE comment#4, maybe it is different problem.

Comment 6

3 years ago
#1 Steps to Reproduce:
1. Start Nightly
2. Make sure default set of toolbar and toolbarbutton 
3. Maximized
4. Exit and restart
5. Press Alt

#2 Steps to Reproduce:
1. Start Nightly
2. Make sure default set of toolbar and toolbarbutton but enable TitleBar
3. Exit and restart
4. Press Alt

Actual Result:
bottom border disappear.

#1: it happens on only maximized mode when browser started with a maximization mode.
#2: it happens on normal/maximized both.

Updated

3 years ago
status-firefox29: --- → affected
status-firefox30: --- → affected

Comment 7

3 years ago
It happens since Australis merge day...
http://hg.mozilla.org/mozilla-central/rev/f2adb62d07eb
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131118075715

Comment 8

3 years ago
Regression window(ux)
Good:
http://hg.mozilla.org/projects/ux/rev/f0305288f605
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131101040202
Bad:
http://hg.mozilla.org/projects/ux/rev/70003bbafecf
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 ID:20131102040205
Pushlog:
http://hg.mozilla.org/projects/ux/pushloghtml?fromchange=f0305288f605&tochange=70003bbafecf

Triggered by:
b48128b81a1f	Dão Gottwald — Bug 933725 - Remove flex="1" from the navigation toolbar. r=gijs
Blocks: 933725
Component: Untriaged → Toolbars and Customization
Keywords: regression

Updated

3 years ago
Whiteboard: [Australis:P3]
(In reply to Alice0775 White from comment #6)
> #1 Steps to Reproduce:
> 1. Start Nightly
> 2. Make sure default set of toolbar and toolbarbutton 
> 3. Maximized
> 4. Exit and restart
> 5. Press Alt
> 
> #2 Steps to Reproduce:
> 1. Start Nightly
> 2. Make sure default set of toolbar and toolbarbutton but enable TitleBar
> 3. Exit and restart
> 4. Press Alt
> 
> Actual Result:
> bottom border disappear.
> 
> #1: it happens on only maximized mode when browser started with a
> maximization mode.
> #2: it happens on normal/maximized both.

I still can't reproduce this, not even with a new profile. I'm on Windows 7 with Aero Glass.

Also, this doesn't really sound like a P3 to me.
Summary: nav-bar bottom border disappears when menubar is shown → nav-bar bottom border disappears when menubar is shown temporarily (when hitting Alt)

Comment 10

3 years ago
(In reply to Dão Gottwald [:dao] from comment #9)
> (In reply to Alice0775 White from comment #6)
> 
> I still can't reproduce this, not even with a new profile. I'm on Windows 7
> with Aero Glass.
> 
> Also, this doesn't really sound like a P3 to me.

It is easy to reproduce on Winsows8.1.(I cannot success reproduce on Windows7)
And you should not use -P or -Profile and other commandline options.

Updated

3 years ago
OS: Windows 7 → Windows 8.1
Whiteboard: [Australis:P3] → [Australis:P4]
(Reporter)

Comment 11

3 years ago
I have this issue on w7x64 with no command line options.

Comment 12

3 years ago
If having a 2px thicker window frame is a P3 (bug 973551), I don't see why this isn't. Seems worse from a "seems glitchy to the user" perspective...
OS: Windows 8.1 → Windows 7
Whiteboard: [Australis:P4] → [Australis:P3]
(In reply to :Gijs Kruitbosch from comment #12)
> If having a 2px thicker window frame is a P3 (bug 973551), I don't see why
> this isn't. Seems worse from a "seems glitchy to the user" perspective...

I'm not sure why you're bringing up a bug that has almost nothing in common with this one. This is merely a minor visual glitch on the navigation toolbar while temporarily interacting the menu bar, while bug 973551 affects the window's appearance permanently. Also, it's still not clear when this bug would occur at all (as I said, I couldn't reproduce it).

https://people.mozilla.org/~mnoorenberghe/australis/ defines P4 as "Minor or polish bugs that are real issues (especially in aggregate), and even annoying", which seems about right.

Updated

3 years ago
Whiteboard: [Australis:P3] → [Australis:P4]
Whiteboard: [Australis:P4] → [Australis:P4+]

Updated

3 years ago
See Also: → bug 981643

Comment 14

3 years ago
(In reply to Dão Gottwald [:dao] from comment #13)
> Also, it's still not clear when this
> bug would occur at all (as I said, I couldn't reproduce it).

This bug is definitely caused by bug 933725.

Comment 15

3 years ago
And, It might be easy to reproduce the problem in case of HWA=off on Windows8.1
I can reproduce this with Direct2D disabled on Windows 7. I wouldn't expect such a dependency if this was a case of ordinary XUL layout quirkiness, so my best guess is that this is a graphics bug.
Component: Toolbars and Customization → Graphics
Product: Firefox → Core
Summary: nav-bar bottom border disappears when menubar is shown temporarily (when hitting Alt) → nav-bar bottom border disappears when menubar is shown temporarily (when hitting Alt) with Direct2D disabled
And I can reproduce this with Firefox 26. Marking P- since it's no Australis regression. I think we might have an older bug filed for this from the days menu bar auto-hiding was enabled.

(In reply to Dão Gottwald [:dao] from comment #16)
> I can reproduce this with Direct2D disabled on Windows 7. I wouldn't expect
> such a dependency if this was a case of ordinary XUL layout quirkiness, so
> my best guess is that this is a graphics bug.

Then again, maybe Direct2D legitimately affects the layout through different font metrics or something and layout fails to handle this properly.
Whiteboard: [Australis:P4+] → [Australis:P-]
Does this still reproduce?
status-firefox29: affected → ---
status-firefox30: affected → ---
Flags: needinfo?(aeidein)
Whiteboard: [Australis:P-] → [Australis:P-][gfx-noted]
Version: 30 Branch → 26 Branch
(Reporter)

Comment 19

9 months ago
I've since upgraded to W10 on a different machine, and it doesn't reproduce.  Can anyone else who was affected give it a try?
Flags: needinfo?(aeidein)
You need to log in before you can comment on or make changes to this bug.