979741 - Use MOZ_DEBUG_CHILD_PROCESS environment variable to stop child forked from Nuwa

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Cervantes Yu [:cyu] [:cervantes]]

In XRE_InitChildProcess() we check the presence of "MOZ_DEBUG_CHILD_PROCESS". If present, we sleep and print out the PID to let developers has the chance to attach to it with a debugger. Nuwa uses #ifdef to do this. We should follow the way the convention in XRE_InitChildProcess().

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Pause Nuwa-spawned child processes by observing the env variable

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

tests: https://tbpl.mozilla.org/?tree=Try&rev=efa76f6a2aa6

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8386034 [details] [diff] [review]
Pause Nuwa-spawned child processes by observing the env variable

Review of attachment 8386034 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/build/Nuwa.cpp
@@ +1561,5 @@
>      CloseAllProtoSockets(sProtoFdInfos, sProtoFdInfosSize);
>    } else {
>      // in the child
> +    if (getenv("MOZ_DEBUG_CHILD_PROCESS")) {
> +      printf("\n\nNUWA CHILDCHILDCHILDCHILD\n  debug me @%d\n\n", getpid());

please add a space between between '@' and '%d' to make blake happy.

Comment 4

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Pause Nuwa-spawned child processes by observing the env variable

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/230cfcce538f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/230cfcce538f