979751 - [Security setting] Redundant "Enter PUK code" page shows after enter incorrect PIN code three times.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Enpei]

Attachment: time stamp: 15:05, 3/5

There are 2 kinds of "Enter PUK code"(puk2.png) page shows after entering incorrect PIN code 3 times. The one with orange title should not be seen after input incorrect PIN 3 times in the Settings. Because even after enter correct information on the orange one, it will back to Settings' "Enter PUK code"(puk1.png) page which will confuse user.

* Build Number
Buri
Gaia      71f78f7f68fcf5e23cc5965fee0dad45289c438b
Gecko     https://hg.mozilla.org/mozilla-central/rev/5dc091b7e86f
BuildID   20140304160205
Version   30.0a1
  
Fugu
Gaia      6781459a49642ca0eb7ec3e95667808d5d77b656
Gecko     d574219c44f75c9dfb007274e9de0479ef51020a
BuildID   20140305053055
Version   30.0a1

* Reproduce Steps
1. Go to Settings > Security, enable PIN but enter incorrect PIN code three times.
2. You will see puk1.png first then puk2.png right away.
3. After enter correct PUK and PIN info on puk2.png, it will go to puk1.png again.

* Expected Result
Only one enter PUK code page.

* Actual Result
There are 2 PUK code page.

* Occurrence rate
100%

Comment 1

[Enpei]

Attachment: PUK1.png

Comment 2

[Enpei]

Attachment: PUK2.png

Comment 3

[Jason Smith [:jsmith]]

Sounds like a regression. Can someone confirm this doesn't reproduce on 1.3?

Comment 4

[Enpei]

(In reply to Jason Smith [:jsmith] from comment #3)
> Sounds like a regression. Can someone confirm this doesn't reproduce on 1.3?

Buri 1.3 also has the problem.

Gaia      8aed4fafbaeb86d6884d31ce7d3cbeb87bcbf837
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/8c27e5488333
BuildID   20140305164002
Version   28.0

Comment 5

[Jason Smith [:jsmith]]

ok - does this happen on 1.1 as well?

Comment 6

[Enpei]

What I would concern more about is whether we should add test case for this case since that https://moztrap.mozilla.org/manage/case/3439/ didn't specify where to input PUK code. If we input incorrect PIN code 3 times in system dialog(orange one), we won't discover it.

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

After some offline discussions with Arthur, because in DSDS we would make settings app monitor the same `cardstatechange` makes this problem happen. And also, we checked related codes in v1.2 found that there is only system dialog would pop up because we didn't monitor this event.

To make it consistent with previous versions, we thought the better way is to remove this event on settings app and left this popup dialog logic in system app only.

Comment 8

[J Zimbrick]

(In reply to Jason Smith [:jsmith] from comment #5)
> ok - does this happen on 1.1 as well?

This issue does not occur on 1.1.

After entering the PUK code and creating a new SIM PIN, the screen will be dismissed and the user is taken back to the "SIM security" menu.

Environmental Variables:
Device: Buri
BuildID: 20140306041201
Gaia: 44a2ddf63373f8e95c784faf4ed4d60081699c61
Gecko: 1421a6b7fc51
Version: 18.0
Base Image: V1.2-device.cfg

Adding regression tags.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I tested this and made sure that this issue happened from v1.2

Gaia      539a25e1887b902b8b25038c547048e691bd97f6
Gecko     https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/eb43649f2837
BuildID   20140306164003
Version   26.0
ro.build.version.incremental=eng.cltbld.20130410.100924
ro.build.date=Wed Apr 10 10:09:30 EDT 2013

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Based on our offline discussions with Carrie, any scenario about `cardstaechange` would be left to system's dialog while the others would be left to settings's dialog in settings app.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on v1.3

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch on master

Comment 13

[J Zimbrick]

Not sure how useful this will be given comments 11 and 12, but I have the regression window.

Unfortunately there is a gap in our locally saved tinderbox builds, so this is the closest window I could get. There's 3 builds between the two listed here.

Regression Window:

Last Working Environmental Variables:
Device: Buri
BuildID: 20140123124523
Gaia: 290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko: 4cd99f870618
Version: 29.0a1
Base Image: V1.2-device.cfg

First Broken Environmental Variables:
Device: Buri
BuildID: 20140124120605
Gaia: 48637bedf20a7d1b8cc3f1638e72eeb44728f467
Gecko: 76f4b3a10154
Version: 29.0a1
Base Image: V1.2-device.cfg

Last Working Gaia/First Broken Gecko: Issue does NOT reproduce.
Gaia: 290efee3de3a12c9d803f4650d50bc7c7a8e1f2d
Gecko: 76f4b3a10154

First Broken Gaia/Last Working Gecko: Issue DOES reproduce.
Gaia: 48637bedf20a7d1b8cc3f1638e72eeb44728f467
Gecko: 4cd99f870618

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/290efee3de3a12c9d803f4650d50bc7c7a8e1f2d...48637bedf20a7d1b8cc3f1638e72eeb44728f467

Comment 14

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8387411 [details] [review]
patch on master

Hi Arthur,

please help me review this patch ! Thanks :P

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8387410 [details] [review]
patch on v1.3

Hi Arthur,

please help me review this patch ! Thanks :P

Comment 16

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8387410 [details] [review]
patch on v1.3

r=me. Please land with travis green, thanks!

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8387411 [details] [review]
patch on master

r=me. Please land with travis green, thanks!

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8387410 [details] [review]
patch on v1.3

Hi Fabrice, 

this is 1.3+ bug and I need your approval to land this patch.

Based on our discussions above, currently there are two popup dialogs showing up when users got puklocked. After some offline discussions with Carrie and Arthur, we think the better way to ask settings app not to listen for this event change and leave this for system app. 

Thanks !!

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch was merged on : 

Gaia/master : e61dc0019d9d6135d88ba15153c37f73a952567e
Gaia/v1.3 : df157ce3a3f841850a1cce8f057f8e7f547fb9f8

Comment 20

[Enpei]

Verified on 1.4 fugu. Will verify on 1.3 tomorrow.
Fugu
Gaia      85a5c0b6d7501c58db83b0fb8d6fe5e6346ad800
Gecko     a96dd5a386e6f9fabb9be9da477e27c0d3adb3ef
BuildID   20140312181422
Version   30.0a1

Comment 21

[Enpei]

Verified on Buri 1.3

Gaia      6194def5ceed3f4b9bc9de0ea2c11661cd439a27
Gecko     https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/9368fd13bfa6
BuildID   20140312164001
Version   28.0