979764 - [keyboard refactor] resizeTo would be invoked more than once when keyboard relaunch

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #958663 +++

When investigating the original keyboard cold launch issue, I found with the new keyboard (demo-keyboard), it would invoke resizeWindow() more than once, and I think this might make the profiling result not that accurate.

So, I am going to look into this first.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Patch V1 - pull request 17026

Hi all,

This patch attempt to address the issue that the new keyboard app would invoke window.resizeTo() more than once, which may cause performance issue.

 1. Wait until 'load' event to do app.start(). 
 2. Not to do resizeWindow(), which would do window.resizeTo(), until the app is shown.

With the above 2 checks, we could minimize the window.resizeTo() called only once when the app is re-launched from scratch.

==
Note: after checking, the app would receive "resize" event twice even when the app itself does nothing (remove all the CSS/Js code) and even I started the 'resize' event listener after 'load' event.

Tim, David,

May need your help to take a look and give feedbacks.
Thanks.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Merged to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/da462713511bf9c573b8bef97a30e64c50680ddf