979827 - [Build] check node version of environment.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

We should check the version of nodejs in case that user's nodejs is too old to run gaia.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to bubble-tea

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8386015 [details] [review]
PR to bubble-tea

Hi Yuren,
could you help me to review this patch? 
When user try to make but the node version is less than what package.json is defined, then we'll print msg in yellow.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8386015 [details] [review]
PR to bubble-tea

We should only check the majar version change such as 0.8 -> 0.10 to only ensure using same APIs and keep it simple.

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8386015 [details] [review]
PR to bubble-tea

Hi Yuren,
patch's updated, we only check the major version of nodejs,
please kindly check again, thanks.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8390996 [details] [review]
PR to master

Hi Yuren,
travis is all green, would you mind to check this patch? Thanks.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8390996 [details] [review]
PR to master

let's check it in makefile, please see my comments on github.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8390996 [details] [review]
PR to master

Thanks, I updated, please kindly check again!

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8390996 [details] [review]
PR to master

r=yurenju, thanks!

Comment 10

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks, 
merge into master 
https://github.com/mozilla-b2g/gaia/commit/c23af48b0a02667ae378bd32e8ae60eaced8e4c1

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to revert this for breaking B2G desktop builds on TBPL.
https://github.com/mozilla-b2g/gaia/commit/190bb06a61f045a6b8f05b6be51602de8ec67059


The failure looked like this:

make[5]: Entering directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/obj-firefox/b2g/gaia'
../../dist/bin/nsinstall -R -m 755 'b2g' '../../dist/bin'
make -j1 -C /builds/slave/b2g-in-l64_g-00000000000000000/build/gaia clean
cut: only one type of list may be specified
Try `cut --help' for more information.
/bin/bash: node: command not found
cut: only one type of list may be specified
Try `cut --help' for more information.
make[6]: Entering directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/gaia'
make[6]: warning: -jN forced in submake: disabling jobserver mode.
rm -rf profile profile-debug profile-test profile build_stage docs
make[6]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/gaia'
make -j1 -C /builds/slave/b2g-in-l64_g-00000000000000000/build/gaia profile
cut: only one type of list may be specified
Try `cut --help' for more information.
/bin/bash: node: command not found
cut: only one type of list may be specified
Try `cut --help' for more information.
make[6]: Entering directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/gaia'
make[6]: warning: -jN forced in submake: disabling jobserver mode.
wget -q -c https://github.com/mozilla-b2g/gaia-node-modules/tarball/master
mv master "modules.tar"
tar --wildcards --strip-components 1 -x -m -f modules.tar "mozilla-b2g-gaia-node-modules-*/node_modules"
npm install && npm rebuild
/bin/bash: npm: command not found
make[6]: *** [node_modules] Error 127
make[6]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/gaia'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/obj-firefox/b2g/gaia'
make[4]: *** [b2g/gaia/libs] Error 2
make[4]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/obj-firefox'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/obj-firefox'
make[2]: *** [default] Error 2
make[2]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build/obj-firefox'
make[1]: *** [realbuild] Error 2
make[1]: Leaving directory `/builds/slave/b2g-in-l64_g-00000000000000000/build'
make: *** [build] Error 2
State Changed: unlock buildroot
program finished with exit code 2

Comment 12

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Will run on try-server.

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8392698 [details] [review]
PR to master

https://tbpl.mozilla.org/?tree=Try&rev=ed554a964738
Travis pass.

The patch will check the node version if the env support node.
Please kindly review it again. Thanks!

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

comment13 typo 
tbpl is green

Comment 15

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8392698 [details] [review]
PR to master

r=yurenju if nit is addressed

Comment 16

[(Inactive after June) George Duan [:gduan] [:喬智]]

Merge to master,
https://github.com/mozilla-b2g/gaia/commit/11d6cd3d50c5a92a85a738a8de5a36932c8a89e6

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Reverted for bustage.
https://github.com/mozilla-b2g/gaia/commit/acf31050ef2f1d2de18e451eebb95436b6a7c96b

https://tbpl.mozilla.org/php/getParsedLog.php?id=36388554&tree=B2g-Inbound

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

push to master again

Comment 19

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8617074 [details] [review]
PR to master

Hi Ricky,
it's an old bug which will make sure node's major version is what our build script expect. Please kindly check.

Comment 20

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8617074 [details] [review]
PR to master

Well done George! I put a nit on Github and let's land it!

Comment 21

[(Inactive after June) George Duan [:gduan] [:喬智]]

thanks, master: https://github.com/mozilla-b2g/gaia/commit/328f2705b790a0cc967eb71a4604c896a6be011a

Comment 22

[Julien Wajsberg [:julienw]]

I get this error on my Debian stable after this commit:
  cut: only one type of list may be specified

You need to use "-f 1,2" or "-f1,2".

But "cut" is not really cross platform, so you should really consider awk:

  echo $(NODE_VERSION) | awk -F. '{ print $1, $2 }

In the mean time I backout this patch, sorry.

reverted on master: 0d25492801f93fb78bc65d06176c79de5fd86ee5

Comment 23

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Julien,
Thanks, I use sed command instead. 
Could you kindly help to review it?
Thanks!

Comment 24

[Julien Wajsberg [:julienw]]

Comment on attachment 8622339 [details] [review]
PR to master

I prefer the version that uses awk because I find it's more readable, but if you prefer to land the sed version please do -- both work for me.

Comment 25

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks for your comments on github!
in makefile using awk -F. '{ print $$1, $$2 } instead.

master: 
https://github.com/mozilla-b2g/gaia/commit/9ecbc39ec1c641e7520757b84839025189457b7c

Comment 26

[Aus Lacroix [:aus]]

I think we could've used this https://docs.npmjs.com/files/package.json#engines

Along with engineStrict which we already use for ensuring npm v2.x is installed.