979947 - Engineering Builds of B2G should enable profiling by default

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P1)

Description

[Mason Chang [Inactive] [:mchang]]

Currently, to get a profiling build, the .userconfig needs MOZ_PROFILING=1. Change it so that if someone is building an engineering build, MOZ_PROFILING is already enabled.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: https://github.com/mozilla-b2g/B2G/pull/327

Enables the profiler by default on engineering builds. Shouldn't affect performance unless we're already running the profiler.

Comment 3

[Mason Chang [Inactive] [:mchang]]

Attachment: https://github.com/mozilla-b2g/gonk-misc/pull/154

Onto the gonk-misc repo! Thanks for the pointer.

Comment 4

[Mason Chang [Inactive] [:mchang]]

Attachment: https://github.com/mozilla-b2g/gonk-misc/pull/155/files

Another one that just enables profiling. I've never heard of B2G_PROFILING before, but I looked in configure.in. --enable-profiling exports MOZ_PROFILING=1, so we don't need MOZ_PROFILING anywhere. Good eye!

Comment 5

[Gabriele Svelto [:gsvelto]]

(In reply to Mason Chang [:mchang] from comment #4)
> Another one that just enables profiling. I've never heard of B2G_PROFILING
> before, but I looked in configure.in.

Setting B2G_PROFILING already includes --enable-profiling, see here:

https://github.com/mozilla-b2g/gonk-misc/blob/1788b0e3fb119501d34a5df537bd5614d5f16546/default-gecko-config#L49

This is what people have been relying on until now IIRC.

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 8387961 [details] [diff] [review]
https://github.com/mozilla-b2g/gonk-misc/pull/155/files

Looks good.

Comment 7

[Mason Chang [Inactive] [:mchang]]

Thanks! Landed in gonk-misc - 266bca6e60dad43e395f38b66edabe8bdc882334