Closed
Bug 979983
Opened 11 years ago
Closed 11 years ago
Fix gjslint issues on v1.3
Categories
(Firefox OS Graveyard :: Gaia::First Time Experience, defect)
Tracking
(b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 unaffected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| b2g-v1.3 | --- | fixed |
| b2g-v1.3T | --- | fixed |
| b2g-v1.4 | --- | unaffected |
People
(Reporter: julienw, Assigned: julienw)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
Unfortunately we still use gjslint on the v1.3 branch.
See https://travis-ci.org/mozilla-b2g/gaia/jobs/20142766
Attachment #8386242 -
Flags: review?(fernando.campo)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Hey Fernando, can you have a look to this quick patch? :)
Flags: needinfo?(fernando.campo)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8386242 [details] [review]
Gaia github PR
thanks for fixing this, I didn't realize :(
Attachment #8386242 -
Flags: review?(fernando.campo) → review+
Flags: needinfo?(fernando.campo)
|
|
Assignee | |
Comment 4•11 years ago
|
||
master: e8bf7326ce5ed63bc8ef8b2cff1eba094887b9bf
thanks, no problem, this is a hole we have right now :(
I really want to take time to set up some rules with https://github.com/mdevils/node-jscs to help with it but too many blockers right now :(
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•11 years ago
|
||
oops sorry, it was v1.3 and not master, and it was a=tests.
Cc fabrice so that he knows about it and won't hit me.
status-b2g-v1.3:
--- → fixed
|
||
Updated•11 years ago
|
status-b2g-v1.3T:
--- → fixed
status-b2g-v1.4:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•