980035 - Support 16bit volatile buffer backed decoded images

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Michael Wu [:mwu]]

Attachment: 16bit-direct-vbuf

Right now, the volatile buffer is thrown away if it is "optimized". This avoids that was on android/gonk when we're using 16bpp images.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8386311 [details] [diff] [review]
16bit-direct-vbuf

Review of attachment 8386311 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Michael. Thanks.

Are there tests for this code?

Comment 2

[Michael Wu [:mwu]]

(In reply to Seth Fowler [:seth] from comment #1)
> Are there tests for this code?

For the optimization/deoptimization path, I think any test which goes through the scaled image path in RasterImage.cpp should cover this.  (assuming they exist - maybe a bad assumption)

For recovery from lost images, I was thinking of adding a code to purge every volatile buffer so those paths can be automatically tested on every platform. Right now I have platform specific test programs that I manually run to test the different redecoding paths.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/efba9e32aca1

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/efba9e32aca1

Comment 5

[Michael Wu [:mwu]]

Attachment: 16 bit volatile buffer images for v1.3t

Here's a version for tarako.

Comment 6

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/ef10dfc5b3cc