Closed Bug 980035 Opened 6 years ago Closed 6 years ago

Support 16bit volatile buffer backed decoded images

Categories

(Core :: ImageLib, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(2 files)

Right now, the volatile buffer is thrown away if it is "optimized". This avoids that was on android/gonk when we're using 16bpp images.
Attachment #8386311 - Flags: review?(seth)
blocking-b2g: --- → 1.3T?
blocking-b2g: 1.3T? → 1.3T+
Comment on attachment 8386311 [details] [diff] [review]
16bit-direct-vbuf

Review of attachment 8386311 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Michael. Thanks.

Are there tests for this code?
Attachment #8386311 - Flags: review?(seth) → review+
(In reply to Seth Fowler [:seth] from comment #1)
> Are there tests for this code?

For the optimization/deoptimization path, I think any test which goes through the scaled image path in RasterImage.cpp should cover this.  (assuming they exist - maybe a bad assumption)

For recovery from lost images, I was thinking of adding a code to purge every volatile buffer so those paths can be automatically tested on every platform. Right now I have platform specific test programs that I manually run to test the different redecoding paths.
https://hg.mozilla.org/mozilla-central/rev/efba9e32aca1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Here's a version for tarako.
You need to log in before you can comment on or make changes to this bug.